-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining emberAfPostAttributeChangeCallback consumers. #10749
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-callbacks
Oct 21, 2021
Merged
Fix remaining emberAfPostAttributeChangeCallback consumers. #10749
Damian-Nordic
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-callbacks
Oct 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were missed in project-chip#10315
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
tcarmelveilleux,
turon,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
October 21, 2021 03:21
saurabhst
approved these changes
Oct 21, 2021
msandstedt
approved these changes
Oct 21, 2021
PR #10749: Size comparison from 6e22d13 to 50c2888 8 builds (for k32w, p6, qpg, telink)
14 builds (for efr32, linux, mbed)
12 builds (for esp32, nrfconnect)
|
Size increase report for "esp32-example-build" from 6e22d13
Full report output
|
yunhanw-google
approved these changes
Oct 21, 2021
Damian-Nordic
approved these changes
Oct 21, 2021
hank820
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Oct 27, 2021
Reference from c4a4361 Fix remaining emberAfPostAttributeChangeCallback consumers. (project-chip#10749)
hank820
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Oct 27, 2021
Reference from c4a4361 Fix remaining emberAfPostAttributeChangeCallback consumers. (project-chip#10749)
hank820
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Oct 28, 2021
Reference from c4a4361 Fix remaining emberAfPostAttributeChangeCallback consumers. (project-chip#10749)
hank820
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Oct 28, 2021
Reference from c4a4361 Fix remaining emberAfPostAttributeChangeCallback consumers. (project-chip#10749)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were missed in #10315
Problem
Virtual LEDs on m5stack don't work.
Change overview
Fix up all the callbacks that were missed in #10315
Testing
Virtual LEDs on m5stack work now. Hopefully the signature update for the other platforms is right too....