Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviewers #10733

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Add reviewers #10733

merged 2 commits into from
Oct 21, 2021

Conversation

woody-apple
Copy link
Contributor

@woody-apple woody-apple commented Oct 20, 2021

Problem

Adding Espressif & LG reviewers

Change overview

Updating Pull Approve

Testing

• CI Testing

@github-actions
Copy link

github-actions bot commented Oct 20, 2021

PR #10733: Size comparison from 05cdfbf to 5a1ed30

5 builds (for p6, qpg, telink)
platform target config section 05cdfbf 5a1ed30 change % change
p6 lock-app default .bss 68208 68208 0 0.0
.data 2416 2416 0 0.0
.heap 962720 962720 0 0.0
.text 1126584 1126584 0 0.0
qpg lighting-app qpg6100+debug .bss 53552 53552 0 0.0
.data 996 996 0 0.0
.text 486640 486640 0 0.0
lock-app qpg6100+debug .bss 52496 52496 0 0.0
.data 952 952 0 0.0
.text 462716 462716 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70992 70992 0 0.0
noinit 33216 33216 0 0.0
text 458354 458354 0 0.0
17 builds (for efr32, k32w, linux, mbed)
platform target config section 05cdfbf 5a1ed30 change % change
efr32 lighting-app BRD4161A .bss 118028 118028 0 0.0
.data 1800 1800 0 0.0
.text 782928 782928 0 0.0
lock-app BRD4161A .bss 115884 115884 0 0.0
.data 1760 1760 0 0.0
.text 762072 762072 0 0.0
window-app BRD4161A .bss 116204 116204 0 0.0
.data 1764 1764 0 0.0
.text 762980 762980 0 0.0
lighting-app BRD4161A+rpc .bss 131356 131356 0 0.0
.data 1852 1852 0 0.0
.text 762652 762652 0 0.0
k32w lock-app k32w061+debug .bss 69060 69060 0 0.0
.data 1864 1864 0 0.0
.text 515552 515552 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 357332 357332 0 0.0
lighting-app k32w061+se05x+release .bss 78584 78584 0 0.0
.data 1900 1900 0 0.0
.text 614336 614336 0 0.0
linux all-clusters-app debug .bss 52176 52176 0 0.0
.data 978 978 0 0.0
.data.rel.ro 59072 59072 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 136245 136245 0 0.0
.text 1342034 1342034 0 0.0
chip-tool debug .bss 17520 17520 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 91920 91920 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 184036 184036 0 0.0
.text 3457109 3457109 0 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23176 23176 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110024 110024 0 0.0
.text 1010018 1010018 0 0.0
ota-requestor-app debug .bss 205696 205696 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 128776 128776 0 0.0
.text 1129810 1129810 0 0.0
shell debug .bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35120 35120 0 0.0
.dynamic 592 592 0 0.0
.got 3496 3496 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 71823 71823 0 0.0
.text 569842 569842 0 0.0
tv-app debug .bss 216560 216560 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 56096 56096 0 0.0
.dynamic 592 592 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153384 153384 0 0.0
.text 1444434 1444434 0 0.0
bridge-app debug+rpc .bss 52880 52880 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110620 110620 0 0.0
.text 1051109 1051109 0 0.0
lighting-app debug+rpc .bss 42200 42200 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52496 52496 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127825 127825 0 0.0
.text 1251330 1251330 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172092 172092 0 0.0
.data 5464 5464 0 0.0
.heap 858888 858888 0 0.0
.text 1220208 1220208 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171012 171012 0 0.0
.data 5432 5432 0 0.0
.heap 860000 860000 0 0.0
.text 1198040 1198040 0 0.0
12 builds (for esp32, nrfconnect)
platform target config section 05cdfbf 5a1ed30 change % change
esp32 all-clusters-app c3devkit .dram0.bss 60320 60320 0 0.0
.dram0.data 16200 16200 0 0.0
.flash.rodata 199120 199120 0 0.0
.flash.text 872714 872714 0 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62824 62824 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207872 207872 0 0.0
.flash.text 903767 903855 88 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112476 112476 0 0.0
rodata 97776 97776 0 0.0
text 577804 577804 0 0.0
lock-app nrf52840dk_nrf52840 bss 111544 111544 0 0.0
rodata 94112 94112 0 0.0
text 559292 559292 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45772 45772 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111612 111612 0 0.0
rodata 95092 95092 0 0.0
text 562448 562448 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111552 111552 0 0.0
rodata 94172 94172 0 0.0
text 559084 559084 0 0.0
shell nrf52840dk_nrf52840 bss 107316 107316 0 0.0
rodata 71640 71640 0 0.0
text 519032 519032 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108720 108720 0 0.0
rodata 88560 88560 0 0.0
text 551004 551004 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113852 113852 0 0.0
rodata 93016 93016 0 0.0
text 507268 507268 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112916 112916 0 0.0
rodata 89372 89372 0 0.0
text 488752 488752 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 108300 108300 0 0.0
rodata 66284 66284 0 0.0
text 439632 439632 0 0.0

@andy31415
Copy link
Contributor

Fast track rationale: does not affect main codebase - it involves testing and reviewing

@andy31415 andy31415 merged commit 3672e84 into project-chip:master Oct 21, 2021
@woody-apple woody-apple deleted the add-reviewers branch July 6, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants