-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove single entrance protection for registerAttributeAccessOverride #10474
Closed
yufengwangca
wants to merge
1
commit into
project-chip:master
from
yufengwangca:pr/cluster/descriptor
Closed
Remove single entrance protection for registerAttributeAccessOverride #10474
yufengwangca
wants to merge
1
commit into
project-chip:master
from
yufengwangca:pr/cluster/descriptor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux and
turon
October 14, 2021 04:32
pullapprove
bot
requested review from
vivien-apple,
wbschiller and
woody-apple
October 14, 2021 04:32
yunhanw-google
approved these changes
Oct 14, 2021
PR #10474: Size comparison from 267951c to 048aed2 34 builds
Increases above 1.0% from 048aed2 to 267951c:
22 builds
12 builds
|
jmartinez-silabs
approved these changes
Oct 14, 2021
bzbarsky-apple
approved these changes
Oct 15, 2021
bzbarsky-apple
requested changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Remove single entrance protection for registerAttributeAccessOverride
Testing
How was this tested? (at least one bullet point required)