Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove single entrance protection for registerAttributeAccessOverride #10474

Closed
wants to merge 1 commit into from
Closed

Remove single entrance protection for registerAttributeAccessOverride #10474

wants to merge 1 commit into from

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Single entrance protection is no more needed after we switch to use MatterDescriptorPluginServerInitCallback to initialize the descriptor cluster server logic since this function is only called once.

Change overview

Remove single entrance protection for registerAttributeAccessOverride

Testing

How was this tested? (at least one bullet point required)

  • confirm MatterDescriptorPluginServerInitCallback is only called once from log

@github-actions
Copy link

github-actions bot commented Oct 14, 2021

PR #10474: Size comparison from 267951c to 048aed2

34 builds
platform target config section 267951c 048aed2 change % change
efr32 lighting-app BRD4161A .bss 118004 118004 0 0.0
.data 1800 1800 0 0.0
.text 780924 780924 0 0.0
lock-app BRD4161A .bss 115876 115876 0 0.0
.data 1760 1760 0 0.0
.text 760172 760172 0 0.0
window-app BRD4161A .bss 116196 116196 0 0.0
.data 1764 1764 0 0.0
.text 761088 761088 0 0.0
lighting-app BRD4161A+rpc .bss 131332 131332 0 0.0
.data 1852 1852 0 0.0
.text 760656 760656 0 0.0
esp32 all-clusters-app c3devkit .dram0.bss 60248 60248 0 0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198144 198144 0 0.0
.flash.text 868962 868962 0 0.0
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62752 62752 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206732 206732 0 0.0
.flash.text 900003 900095 92 0.0
.iram0.text 125115 125115 0 0.0
k32w lock-app k32w061+debug .bss 69036 69036 0 0.0
.data 1864 1864 0 0.0
.text 514056 514056 0 0.0
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 356808 356808 0 0.0
lighting-app k32w061+se05x+release .bss 78552 78552 0 0.0
.data 1900 1900 0 0.0
.text 612732 612732 0 0.0
linux all-clusters-app debug .bss 52144 52144 0 0.0
.data 978 978 0 0.0
.data.rel.ro 58352 58352 0 0.0
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134773 134773 0 0.0
.text 1318226 1318226 0 0.0
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 173664 173664 0 0.0
.text 2425109 2425109 0 0.0
ota-provider-app debug .bss 37472 37472 0 0.0
.data 752 752 0 0.0
.data.rel.ro 23112 23112 0 0.0
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 108824 108824 0 0.0
.text 1005410 1005410 0 0.0
ota-requestor-app debug .bss 205728 205728 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24408 24408 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 126864 126864 0 0.0
.text 1125042 1125042 0 0.0
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 71343 71343 0 0.0
.text 574322 574322 0 0.0
tv-app debug .bss 216368 216368 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55536 55536 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150536 150536 0 0.0
.text 1463730 1463730 0 0.0
bridge-app debug+rpc .bss 52880 52880 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25480 25480 0 0.0
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 109492 109492 0 0.0
.text 1047493 1047493 0 0.0
lighting-app debug+rpc .bss 42200 42200 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 52192 52192 0 0.0
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 126641 126641 0 0.0
.text 1248642 1248642 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172132 172132 0 0.0
.data 5464 5464 0 0.0
.heap 858848 858848 0 0.0
.text 1218656 1218656 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171068 171068 0 0.0
.data 5432 5432 0 0.0
.heap 859944 859944 0 0.0
.text 1196648 1196648 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112304 112304 0 0.0
rodata 97160 97160 0 0.0
text 576856 576856 0 0.0
lock-app nrf52840dk_nrf52840 bss 111336 111336 0 0.0
rodata 93656 93656 0 0.0
text 558300 558300 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111404 111404 0 0.0
rodata 94640 94640 0 0.0
text 561468 561468 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111344 111344 0 0.0
rodata 93716 93716 0 0.0
text 558076 558076 0 0.0
shell nrf52840dk_nrf52840 bss 107320 107320 0 0.0
rodata 71336 71336 0 0.0
text 518964 518964 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108544 108544 0 0.0
rodata 87940 87940 0 0.0
text 550060 550060 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113676 113676 0 0.0
rodata 92400 92400 0 0.0
text 506316 506316 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112708 112708 0 0.0
rodata 88916 88916 0 0.0
text 487752 487752 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 108304 108304 0 0.0
rodata 65980 65980 0 0.0
text 439564 439564 0 0.0
p6 lock-app default .bss 68208 68208 0 0.0
.data 2416 2416 0 0.0
.heap 962720 962720 0 0.0
.text 1124840 1124840 0 0.0
qpg lighting-app qpg6100+debug .bss 53520 53520 0 0.0
.data 996 996 0 0.0
.text 485252 485252 0 0.0
lock-app qpg6100+debug .bss 52472 52472 0 0.0
.data 952 952 0 0.0
.text 461436 461436 0 0.0
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70972 70972 0 0.0
noinit 33216 33216 0 0.0
text 457428 457428 0 0.0

Increases above 1.0% from 048aed2 to 267951c:

platform target config section 267951c 048aed2 change % change
linux chip-tool debug .data.rel.ro 77392 83312 5920 7.6
.init_array 416 424 8 1.9
22 builds
platform target config section 267951c 048aed2 change % change
efr32 lighting-app BRD4161A .bss 118004 118020 16 0.0
.data 1800 1800 0 0.0
.text 780924 781852 928 0.1
lock-app BRD4161A .bss 115876 115892 16 0.0
.data 1760 1760 0 0.0
.text 760172 761124 952 0.1
window-app BRD4161A .bss 116196 116212 16 0.0
.data 1764 1764 0 0.0
.text 761088 762032 944 0.1
lighting-app BRD4161A+rpc .bss 131332 131348 16 0.0
.data 1852 1852 0 0.0
.text 760656 761592 936 0.1
k32w lock-app k32w061+debug .bss 69036 69052 16 0.0
.data 1864 1864 0 0.0
.text 514056 514540 484 0.1
shell k32w061+debug .bss 55080 55080 0 0.0
.data 672 672 0 0.0
.text 356808 356808 0 0.0
lighting-app k32w061+se05x+release .bss 78552 78568 16 0.0
.data 1900 1900 0 0.0
.text 612732 613216 484 0.1
linux all-clusters-app debug .bss 52144 52176 32 0.1
.data 978 978 0 0.0
.data.rel.ro 58352 58416 64 0.1
.dynamic 592 592 0 0.0
.got 4072 4072 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134773 135029 256 0.2
.text 1318226 1321298 3072 0.2
chip-tool debug .bss 17584 17584 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 77392 83312 5920 7.6
.dynamic 592 592 0 0.0
.got 4328 4328 0 0.0
.init 27 27 0 0.0
.init_array 416 424 8 1.9
.rodata 173664 173792 128 0.1
.text 2425109 2422117 -2992 -0.1
ota-provider-app debug .bss 37472 37504 32 0.1
.data 752 752 0 0.0
.data.rel.ro 23112 23192 80 0.3
.dynamic 592 592 0 0.0
.got 4008 4008 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 108824 109080 256 0.2
.text 1005410 1008946 3536 0.4
ota-requestor-app debug .bss 205728 205760 32 0.0
.data 752 752 0 0.0
.data.rel.ro 24408 24488 80 0.3
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 126864 127152 288 0.2
.text 1125042 1128594 3552 0.3
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35184 35184 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 71343 71343 0 0.0
.text 574322 574322 0 0.0
tv-app debug .bss 216368 216400 32 0.0
.data 2032 2032 0 0.0
.data.rel.ro 55536 55568 32 0.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150536 150792 256 0.2
.text 1463730 1466802 3072 0.2
bridge-app debug+rpc .bss 52880 52912 32 0.1
.data 976 976 0 0.0
.data.rel.ro 25480 25512 32 0.1
.dynamic 592 592 0 0.0
.got 3944 3944 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 109492 109748 256 0.2
.text 1047493 1050565 3072 0.3
lighting-app debug+rpc .bss 42200 42232 32 0.1
.data 1106 1106 0 0.0
.data.rel.ro 52192 52256 64 0.1
.dynamic 608 608 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 126641 126897 256 0.2
.text 1248642 1251714 3072 0.2
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172132 172148 16 0.0
.data 5464 5464 0 0.0
.heap 858848 858832 -16 -0.0
.text 1218656 1219128 472 0.0
lock-app CY8CPROTO_062_4343W+release .bss 171068 171084 16 0.0
.data 5432 5432 0 0.0
.heap 859944 859928 -16 -0.0
.text 1196648 1197112 464 0.0
p6 lock-app default .bss 68208 68224 16 0.0
.data 2416 2416 0 0.0
.heap 962720 962704 -16 -0.0
.text 1124840 1125776 936 0.1
qpg lighting-app qpg6100+debug .bss 53520 53536 16 0.0
.data 996 996 0 0.0
.text 485252 485728 476 0.1
lock-app qpg6100+debug .bss 52472 52488 16 0.0
.data 952 952 0 0.0
.text 461436 461912 476 0.1
persistent-storage-app qpg6100+debug .bss 17778 17778 0 0.0
.data 280 280 0 0.0
.text 102704 102704 0 0.0
telink lighting-app tlsr9518adk80d bss 70972 70988 16 0.0
noinit 33216 33216 0 0.0
text 457428 457904 476 0.1
12 builds
platform target config section 267951c 048aed2 change % change
esp32 all-clusters-app c3devkit .dram0.bss 60248 60264 16 0.0
.dram0.data 16232 16232 0 0.0
.flash.rodata 198144 198168 24 0.0
.flash.text 868962 869458 496 0.1
.iram0.text 57330 57330 0 0.0
m5stack .dram0.bss 62752 62768 16 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206732 206756 24 0.0
.flash.text 900003 900551 548 0.1
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112304 112320 16 0.0
rodata 97160 97180 20 0.0
text 576856 577324 468 0.1
lock-app nrf52840dk_nrf52840 bss 111336 111352 16 0.0
rodata 93656 93676 20 0.0
text 558300 558764 464 0.1
pigweed-app nrf52840dk_nrf52840 bss 51772 51772 0 0.0
rodata 45772 45772 0 0.0
text 339392 339392 0 0.0
pump-app nrf52840dk_nrf52840 bss 111404 111420 16 0.0
rodata 94640 94660 20 0.0
text 561468 561936 468 0.1
pump-controller-app nrf52840dk_nrf52840 bss 111344 111360 16 0.0
rodata 93716 93736 20 0.0
text 558076 558540 464 0.1
shell nrf52840dk_nrf52840 bss 107320 107320 0 0.0
rodata 71336 71336 0 0.0
text 518964 518964 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108544 108560 16 0.0
rodata 87940 87960 20 0.0
text 550060 550528 468 0.1
nrf5340dk_nrf5340_cpuapp bss 113676 113692 16 0.0
rodata 92400 92420 20 0.0
text 506316 506780 464 0.1
lock-app nrf5340dk_nrf5340_cpuapp bss 112708 112724 16 0.0
rodata 88916 88936 20 0.0
text 487752 488216 464 0.1
shell nrf5340dk_nrf5340_cpuapp bss 108304 108304 0 0.0
rodata 65980 65980 0 0.0
text 439564 439564 0 0.0

@yufengwangca yufengwangca deleted the pr/cluster/descriptor branch October 14, 2021 16:46
@yufengwangca yufengwangca restored the pr/cluster/descriptor branch October 14, 2021 17:18
@yufengwangca yufengwangca reopened this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants