-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad "building android" link #10424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
@gmarcosb - it seems like restyler/prettier-markdown wants to split 'guide' onto the next line. |
Hey sorry still new to github - that sounds good, it looks like restyle automatically created a pull request @ #10425 is that correct? Can we just merge that one or is there something I need to do? |
I do not think we merge restyle PRs (not sure if there is a reason ... never seen it done though). |
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
October 13, 2021 21:38
pullapprove
bot
requested review from
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
October 13, 2021 21:38
saurabhst
approved these changes
Oct 13, 2021
austinh0
approved these changes
Oct 13, 2021
jmartinez-silabs
approved these changes
Oct 13, 2021
bzbarsky-apple
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Old filename was used for link.
Change overview
Use a correct file name.
Testing
Text typo only, no testing needed.