You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yunhanw-google@vivien-apple if one of you could look this over, I would really appreciated it, just to make sure I am not missing something in the codegen bits.
For now we are still passing the existing arguments to cluster
callbacks, so we don't need to update cluster implementations as part
of this change.
The change to how we encode CHAR_STRING command arguments is needed
because the new setup expects to decode them as TLV UTF-8 strings, not
TLV octet strings.
Size increase report for "gn_qpg-example-build" from 8dc009b
File
Section
File
VM
chip-qpg6100-lighting-example.out
.text
-596
-596
Full report output
BLOAT REPORT
Files found only in the build output:
report.csv
Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:
sections,vmsize,filesize
.debug_info,0,647293
.debug_str,0,303452
.debug_loc,0,298290
.debug_line,0,180444
.debug_ranges,0,69832
.debug_frame,0,25904
.strtab,0,7060
.debug_aranges,0,5464
.debug_abbrev,0,2865
.symtab,0,1904
[Unmapped],0,596
.text,-596,-596
Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:
BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We are passing in structs that are not initialized yet.
Change overview
Fill in the struct members. Get the values we used to decode directly from the struct members.
Testing
Exercised by our existing tests. The only observable behavior changes are the change to expect UTF-8 strings in the payload for CHAR_STRING.