Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies on FabricTable objects #10126

Merged

Conversation

pan-apple
Copy link
Contributor

Problem

A bunch of code is including FabricTable.h that's not really needed. The code could use some cleanup.

Change overview

Removed unnecessary dependency on classes in FabricTable.h file. Also moved FabricTable objects out of Transport namespace. Intention is to eventually move it out of src/transport to higher in the stack.

Testing

Ran gn_build.sh and gn_tests.sh to ensure the builds and tests are not impacted.
Build m5stack image to test the device build.
Performed commissioning of m5stack using chip-tool
CI to test other device builds.

@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 40ac48e

File Section File VM
chip-shell.elf device_handles -12 -12
chip-shell.elf rodata -1472 -1476
chip-shell.elf bss 0 -1568
chip-shell.elf text -13540 -13540
chip-lock.elf device_handles 4 4
chip-lock.elf text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.shstrtab,0,-1
device_handles,-12,-12
rodata,-1476,-1472
bss,-1568,0
.debug_aranges,0,-2168
.debug_frame,0,-7152
.symtab,0,-7488
.strtab,0,-9827
.debug_ranges,0,-13536
text,-13540,-13540
.debug_abbrev,0,-29388
.debug_str,0,-32642
.debug_line,0,-66677
.debug_loc,0,-81846
.debug_info,0,-315751

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_line,0,94
device_handles,4,4
text,-4,-4
.debug_loc,0,-118
.debug_abbrev,0,-157
.strtab,0,-424
.debug_info,0,-601
.debug_str,0,-930


@github-actions
Copy link

Size increase report for "esp32-example-build" from 40ac48e

File Section File VM
chip-all-clusters-app.elf .dram0.bss 0 -8
chip-all-clusters-app.elf .dram0.heap_start 0 -8
chip-all-clusters-app.elf .flash.text -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_ranges,0,24
[Unmapped],0,12
.riscv.attributes,0,-1
.dram0.bss,-8,0
.dram0.heap_start,-8,0
.flash.text,-12,-12
.debug_loc,0,-47
.strtab,0,-424
.debug_str,0,-940
.debug_abbrev,0,-943
.debug_line,0,-1007
.debug_info,0,-68842


@andy31415 andy31415 merged commit 5d4d073 into project-chip:master Sep 30, 2021
@pan-apple pan-apple deleted the cleanup-fabrictable-includes branch September 30, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants