Group Data Provider: RemoveFabric method added. #10119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
vivien-apple,
woody-apple,
yufengwangca and
yunhanw-google
jmartinez-silabs
approved these changes
Sep 30, 2021
|
/rebase |
rcasallas-silabs
force-pushed
the
group_data_provider-remove_fabric
branch
from
8f9e56d
to
ff1c82e
Compare
emargolis
reviewed
Oct 2, 2021
emargolis
approved these changes
Oct 2, 2021
woody-apple
approved these changes
Oct 7, 2021
rcasallas-silabs
force-pushed
the
group_data_provider-remove_fabric
branch
from
ff1c82e
to
5cef70a
Compare
rcasallas-silabs
force-pushed
the
group_data_provider-remove_fabric
branch
from
5cef70a
to
9baf2a4
Compare
tcarmelveilleux
approved these changes
Oct 8, 2021
msandstedt
approved these changes
Oct 10, 2021
rcasallas-silabs
force-pushed
the
group_data_provider-remove_fabric
branch
from
9baf2a4
to
105a080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The GroupDataProvider interface is missing a function to remove all entries related to a given fabric.
Change overview
Testing
Unit tests added with coverage for the feature, and run successfully.