Restyle Move TI hardware acceleration into Matter repo #10030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
Moved the SHA, AES, and ECJPAKE alt headers and source files into the Matter repository. Fixed an issue with the semantics of SHA256 context cloning. Changed the CHIPCryptoPALmbedTLS.cpp implementation to clone the temporary context back over the original context when done with the non-final finalization. Increased the SHA context opaque size in CHIPCryptoPAL.h to fit the TI driver accelerated SHA context. In future commits it may be possible to share a single SHA driver instance between all the contexts in mbedtls. This has the disadvantage of requiring a mutex for driver usage and reference counting. This would also increase processing time due to the thrashing of the internal digest buffer. But has the potential advantage that the SHA context can be copied directly with a memcpy.
The TI BLE Manager Impl incorrectly included a header that required cpp linkage.
The Hash_SHA256_stream object is now created on the stack and let to fall out of context at the end of a translation unit. This causes an issue if the resources are not freed. Update the mbedtls PAL to initialize and free the underlying SHA context structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #9579 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.