Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] TemperatureMeasurement XML contains invalid default values for min/max measured values #30775

Open
Apollon77 opened this issue Dec 2, 2023 · 1 comment
Open

[BUG] TemperatureMeasurement XML contains invalid default values for min/max measured values #30775

Apollon77 opened this issue Dec 2, 2023 · 1 comment
Labels
bug Something isn't working needs triage Spec XML align SDK XML does not match the spec (including naming, etc)

Comments

@Apollon77
Copy link
Contributor

Reproduction steps

The default values for the attributes Min/MaxMeasured Values are invalid because exceed the maximum defined values

see
https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/temperature-measurement-cluster.xml#L28C9-L28C9

Bug prevalence

n/a

GitHub hash of the SDK that was being used

current master

Platform

other

Platform Version(s)

No response

Anything else?

No response
@Apollon77 Apollon77 added bug Something isn't working needs triage labels Dec 2, 2023
This was referenced Dec 2, 2023
Closed
Merged
mergify bot pushed a commit to project-chip/matter.js that referenced this issue Dec 2, 2023
@Apollon77
Fix TemperatureMeasurement definition (#555)
e55209c 
This PR adds a manual override for invalid default values from chip repo (see project-chip/connectedhomeip#30775)
@Apollon77 Apollon77 changed the title [BUG] Temperaturemesaurement XML contains invalid default values for min/max mesaured values [BUG] Temperaturemesaurement XML contains invalid default values for min/max measured values Dec 2, 2023
@Apollon77 Apollon77 changed the title [BUG] Temperaturemesaurement XML contains invalid default values for min/max measured values [BUG] TemperatureMeasurement XML contains invalid default values for min/max measured values Dec 2, 2023
@bzbarsky-apple
Copy link
Contributor

Yep, this is copy/paste from Zigbee which was using the "2s complement bit pattern for a negative number but expressed in hex" thing....

@bzbarsky-apple bzbarsky-apple added the Spec XML align SDK XML does not match the spec (including naming, etc) label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
[Enhancements] Spec/XML Alignment
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Apollon77 @bzbarsky-apple