[ESP32] Various -Wundef compile issues in src/platform/ESP32/CHIPPlatformConfig.h

[bzbarsky-apple]

Reproduction steps

https://github.com/project-chip/connectedhomeip/actions/runs/6419947072/job/17430925276?pr=29582 (from turning on -Wundef in our global compile options).

It looks like src/platform/ESP32/CHIPPlatformConfig.h tests various macros without including the things that would define them. If that is expected, it should be testing defined() or #ifdef:

• CONFIG_ENABLE_ICD_SERVER
• CONFIG_SECURITY_TEST_MODE

INFO    ../../../../config/esp32/third_party/connectedhomeip/src/platform/ESP32/CHIPPlatformConfig.h:79:5: error: "CONFIG_ENABLE_ICD_SERVER" is not defined, evaluates to 0 [-Werror=undef]
INFO       79 | #if CONFIG_ENABLE_ICD_SERVER
INFO          |     ^~~~~~~~~~~~~~~~~~~~~~~~
INFO    ../../../../config/esp32/third_party/connectedhomeip/src/platform/ESP32/CHIPPlatformConfig.h:61:40: error: "CONFIG_SECURITY_TEST_MODE" is not defined, evaluates to 0 [-Werror=undef]
INFO       61 | #define CHIP_CONFIG_SECURITY_TEST_MODE CONFIG_SECURITY_TEST_MODE
INFO          |                                        ^~~~~~~~~~~~~~~~~~~~~~~~~

@dhrishi @shubhamdp

Platform

esp32

Platform Version(s)

No response

Type

CI tested

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response