Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Marking sessions defunct on exhange timeout should probably not happen if the message was acked #29165

Closed
bzbarsky-apple opened this issue Sep 11, 2023 · 0 comments · Fixed by #29173
Closed

[BUG] Marking sessions defunct on exhange timeout should probably not happen if the message was acked #29165

bzbarsky-apple opened this issue Sep 11, 2023 · 0 comments · Fixed by #29173
Labels
bug Something isn't working needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

If we send a message and:

  1. We get an MRP ack for it.
  2. We do not get an application-level response for it in time

we will go ahead and mark the session as defunct. But the session seemed to be fine: we got an ack and decrypted it!

So we should probably not mark the session defunct in this situation.

Bug prevalence

Always

GitHub hash of the SDK that was being used

5ae3c65

Platform

core

Platform Version(s)

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple added bug Something isn't working needs triage labels Sep 11, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 11, 2023
@bzbarsky-apple
Don't mark session defunct on response timeout if the message was acked.
a3bcd83 
If we got an ack, the session is fine and there is no reason to mark it defunct.

Fixes project-chip#29165
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 11, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 13, 2023
@bzbarsky-apple
Don't mark session defunct on response timeout if the message was acked.
90bae8d 
If we got an ack, the session is fine and there is no reason to mark it defunct.

Fixes project-chip#29165
@mergify mergify bot closed this as completed in #29173 Sep 13, 2023
mergify bot pushed a commit that referenced this issue Sep 13, 2023
@bzbarsky-apple
Don't mark session defunct on response timeout if the message was ack…
af635a6 
…ed. (#29173)

* Don't mark session defunct on response timeout if the message was acked.

If we got an ack, the session is fine and there is no reason to mark it defunct.

Fixes #29165

* Address review comment.
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Don't mark session defunct on response timeout if the message was ack…
00f8e4c 
…ed. (project-chip#29173)

* Don't mark session defunct on response timeout if the message was acked.

If we got an ack, the session is fine and there is no reason to mark it defunct.

Fixes project-chip#29165

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
1 participant
@bzbarsky-apple