Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Manufacturer code not used uniformly in the SDK #28813

Open
andy31415 opened this issue Aug 22, 2023 · 0 comments
Open

[BUG] Manufacturer code not used uniformly in the SDK #28813

andy31415 opened this issue Aug 22, 2023 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@andy31415
Copy link
Contributor

andy31415 commented Aug 22, 2023

Reproduction steps

Generally MEI codes do not seem uniformly used and our examples do not use the XML manufacturerCode at all.

Encoding in places like https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/templates/app/ids/Attributes.zapt#L17 or Commands or Events use {{asMEI manufacturerCode code}}

however at the same time other places like https://github.com/project-chip/connectedhomeip/blob/master/examples/chip-tool/templates/commands.zapt#L43 just use code without manufacturerCode at all.

#28805 fixes matter IDL generation, however when trying to change UnitTesting and FaultInjection clusters to be manufacturer extensions I found several inconsistencies like the commands above or python code generation.

GitHub hash of the SDK that was being used

cbc3865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant