[Feature] Review Common Profile Tags Support Within Json-Tlv-Json Convertor

[emargolis]

Feature description

Current Json-Tlv-Json converter supports Context and Common Profile tags. There are some issue associated with that, reflected in the following comments:
https://github.com/project-chip/connectedhomeip/pull/27635/files/f25def68e4127a807121069f11dfd5a411969b38#r1275438623
https://github.com/project-chip/connectedhomeip/pull/27635/files/f25def68e4127a807121069f11dfd5a411969b38#r1275439222

The current implementation requires Common Profile Tag Number to be greater than 255. If the Common Profile tag number is less or equal to 255 it cannot be distinguished from the Context Tag in Json.

@turon @mrjerryjohns @yunhanw-google

Platform

core

Platform Version(s)

No response

Anything else?

No response

[yunhanw-google]

We have decided to replace common profile id with implicit profile id, and would update across kotlin side as well using this ticket.

[yunhanw-google]

From @bzbarsky-apple , So if we had a Common tag that happened to fall into the "less than 256" range, we would treat it as a Context tag?
InternalConvertTlvTag

else if (tagNumber <= UINT32_MAX)
{
    tag = TLV::ProfileTag(profileId, static_cast<uint32_t>(tagNumber));
}

I think we should immediately raise the error when detecting the number within UINT32_MAX range with implicit ProfileId, we have handled this error in

connectedhomeip/src/lib/support/jsontlv/TlvToJson.cpp

Line 181 in eb019b0

VerifyOrReturnError(TLV::TagNumFromTag(tag) > UINT8_MAX, CHIP_ERROR_INVALID_TLV_TAG);

[bzbarsky-apple]

More useful links to the discussion, with my notes:

• Json to Tlv and Tlv to Json Converters Implementation in CPP #27635 (comment) -- this is because we are trying to support things that are not actual data model payloads. The format of these things is not well-defined in the jsontlv API, but needs to be.
• Json to Tlv and Tlv to Json Converters Implementation in CPP #27635 (comment) -- this is fixed per the code cited in [Feature] Review Common Profile Tags Support Within Json-Tlv-Json Convertor #28387 (comment)

[yunhanw-google]

We have updated with implicit profileId, and improve it in #32276