Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] examples/tv-casting-app: Default rotatingDeviceIdUniqueId used to generate/advertise rotatingDeviceId #24400

Open
sharadb-amazon opened this issue Jan 12, 2023 · 0 comments
Open

[BUG] examples/tv-casting-app: Default rotatingDeviceIdUniqueId used to generate/advertise rotatingDeviceId #24400

sharadb-amazon opened this issue Jan 12, 2023 · 0 comments
Assignees
@sharadb-amazon
Labels
examples tv-casting
Milestone
No Target Milestone

Comments

@sharadb-amazon
Copy link
Contributor

Reproduction steps

In the Android/iOS tv-casting-app, sometimes the default random uniqueId is used to generate the rotatingDeviceId.
Expected: If the client app code passes a rotatingDeviceIdUniqueId, we should always only generate any rotatingDeviceIds using the passed in rotatingDeviceIdUniqueId.

Bug prevalence

Sometimes

GitHub hash of the SDK that was being used

dd6ae93

Platform

android

Platform Version(s)

No response

Anything else?

No response
@sharadb-amazon sharadb-amazon mentioned this issue Jan 12, 2023
Merged
chrisdecenzo pushed a commit that referenced this issue Jan 25, 2023
@sharadb-amazon
tv-casting-app: Fixes for #24399 and #24400 (#24401)
b736651 
* iOS tv-casting-app: Re-init binding handlers in startMatterServer API

* tv-casting-app: Disconnecting from previous video player before connecting to the new one

* Moving SetRotatingDeviceIdUniqueId to preInitApp so it always happens before- Matter server is initialized
iOS tv-casting-app: Changed initApp to initializeApp and added return value

* Addressing andy31415@'s feedback
sharadb-amazon added a commit to sharadb-amazon/connectedhomeip that referenced this issue Jan 25, 2023
@sharadb-amazon
tv-casting-app: Fixes for project-chip#24399 and project-chip#24400 (p…
6a0c2c0 
…roject-chip#24401)

* iOS tv-casting-app: Re-init binding handlers in startMatterServer API

* tv-casting-app: Disconnecting from previous video player before connecting to the new one

* Moving SetRotatingDeviceIdUniqueId to preInitApp so it always happens before- Matter server is initialized
iOS tv-casting-app: Changed initApp to initializeApp and added return value

* Addressing andy31415@'s feedback
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@sharadb-amazon
tv-casting-app: Fixes for project-chip#24399 and project-chip#24400 (p…
ba52ff2 
…roject-chip#24401)

* iOS tv-casting-app: Re-init binding handlers in startMatterServer API

* tv-casting-app: Disconnecting from previous video player before connecting to the new one

* Moving SetRotatingDeviceIdUniqueId to preInitApp so it always happens before- Matter server is initialized
iOS tv-casting-app: Changed initApp to initializeApp and added return value

* Addressing andy31415@'s feedback
@woody-apple woody-apple added this to the Future milestone Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharadb-amazon sharadb-amazon

Labels
examples tv-casting
Projects
[Device Type] TV & Media
Status: Todo
Milestone
No Target Milestone
Development

No branches or pull requests
2 participants
@sharadb-amazon @woody-apple