Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Add a timeout parameter to MTRNetworkCommissioningClusterScanNetworksParams #24333

Closed
kpark-apple opened this issue Jan 9, 2023 · 0 comments · Fixed by #24552
Closed

Comments

@kpark-apple
Copy link
Contributor

Reproduction steps

When issuing -[MTRBaseClusterNetworkCommissioning scanNetworksWithParams:completion:] or -[MTRClusterNetworkCommissioning scanNetworksWithParams:expectedValues:expectedValueInterval:completion:], app cannot specify transaction timeout hence forced to use default transaction timeout which may be too short for some server platforms, causing transaction timeout on the client side while the server is still collecting scan results.

Adding a transaction timeout parameter to the command parameters and using that timeout would enable client side app to use longer timeout appropriate for the specific server.

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

The scan networks command was exercised against real server node.

Anything else?

No response

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 20, 2023
…out.

The default 2s timeout is way too low for some commands (like ScanNetworks).

Fixes project-chip#24333
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 20, 2023
…out.

The default 2s timeout is way too low for some commands (like ScanNetworks).

Fixes project-chip#24333
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 20, 2023
…out.

The default 2s timeout is way too low for some commands (like ScanNetworks).

Fixes project-chip#24333
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 20, 2023
…out.

The default 2s timeout is way too low for some commands (like ScanNetworks).

Fixes project-chip#24333
bzbarsky-apple added a commit that referenced this issue Jan 21, 2023
…out. (#24552)

The default 2s timeout is way too low for some commands (like ScanNetworks).

Fixes #24333
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
…out. (#24552)

The default 2s timeout is way too low for some commands (like ScanNetworks).

Fixes project-chip/connectedhomeip#24333
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
…out. (#24552)

The default 2s timeout is way too low for some commands (like ScanNetworks).

Fixes project-chip/connectedhomeip#24333
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
…out. (project-chip#24552)

The default 2s timeout is way too low for some commands (like ScanNetworks).

Fixes project-chip#24333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants