Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to do ExtractVIDPIDFromX509Cert via the Darwin framework #23338

Closed
bzbarsky-apple opened this issue Oct 25, 2022 · 2 comments · Fixed by #24335
Closed

Add a way to do ExtractVIDPIDFromX509Cert via the Darwin framework #23338

bzbarsky-apple opened this issue Oct 25, 2022 · 2 comments · Fixed by #24335
Assignees

Comments

@bzbarsky-apple
Copy link
Contributor

This is needed to figure out the VID/PID of the device, as claimed in its DAC, after device attestation completes.

@bzbarsky-apple
Copy link
Contributor Author

bzbarsky-apple commented Oct 25, 2022

Perhaps this API shape:

typedef NSData * MTRDeviceAttestationCertificate;

@interface MTRProductIdentity : NSObject / * Name TBD */
@property (nonatomic, readonly) NSNumber * vendorID;
@property (nonatomic, readonly) NSNumber * productID;

- (instancetype)productIdentityFromDeviceAttestationCertificate:(MTRDeviceAttestationCertificate)deviceAttestationCertificate error:(NSError * __autoreleasing *)error;

- (instancetype)init NS_UNAVAILABLE;
+ (instancetype)new NS_UNAVAILABLE;
@end

or so. Or should the "From" there be "With"?

@woody-apple
Copy link
Contributor

I’d vote with. :)

@ksperling-apple ksperling-apple self-assigned this Dec 13, 2022
ksperling-apple added a commit to ksperling-apple/connectedhomeip that referenced this issue Jan 10, 2023
ksperling-apple added a commit to ksperling-apple/connectedhomeip that referenced this issue Jan 10, 2023
andy31415 pushed a commit that referenced this issue Jan 10, 2023
…DeviceInfo (#24335)

* Add Xcode file header templates

* Add vendorID and productID properties to MTRDeviceAttestationDeviceInfo

Fixes #23338
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
…DeviceInfo (project-chip#24335)

* Add Xcode file header templates

* Add vendorID and productID properties to MTRDeviceAttestationDeviceInfo

Fixes project-chip#23338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants