Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Switch MTRSubscribeParams nullable booleans to just BOOL #22536

Closed
bzbarsky-apple opened this issue Sep 12, 2022 · 0 comments · Fixed by #22592
Closed

[Platform] Switch MTRSubscribeParams nullable booleans to just BOOL #22536

bzbarsky-apple opened this issue Sep 12, 2022 · 0 comments · Fixed by #22592
Assignees
@bzbarsky-apple
Labels
darwin V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 12, 2022 •
edited
Loading

Reproduction steps

Instead of "null means default", just pre-init to default and then consumers can set it to whatever as desired.

Probably safe to do in parallel with #22531.

Part of #22420

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple self-assigned this Sep 12, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 13, 2022
@bzbarsky-apple
Apply API review fixes for MTRReadParams and MTRSubscribeParams.
928fea2 
* Move minInterval and maxInterval into MTRSubscribeParams.

* Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to
  the default) instead of "NSNumber with nil meaning default".

Fixes project-chip#22536
Fixes project-chip#22534

Addresses part of project-chip#22420
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 13, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 13, 2022
@bzbarsky-apple
Apply API review fixes for MTRReadParams and MTRSubscribeParams.
967dc7d 
* Move minInterval and maxInterval into MTRSubscribeParams.

* Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to
  the default) instead of "NSNumber with nil meaning default".

Fixes project-chip#22536
Fixes project-chip#22534

Addresses part of project-chip#22420
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 13, 2022
@bzbarsky-apple
Apply API review fixes for MTRReadParams and MTRSubscribeParams.
b2b8cf3 
* Move minInterval and maxInterval into MTRSubscribeParams.

* Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to
  the default) instead of "NSNumber with nil meaning default".

Fixes project-chip#22536
Fixes project-chip#22534

Addresses part of project-chip#22420
bzbarsky-apple added a commit that referenced this issue Sep 14, 2022
@bzbarsky-apple
Apply API review fixes for MTRReadParams and MTRSubscribeParams. (#22592
72d838a 
)

* Move minInterval and maxInterval into MTRSubscribeParams.

* Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to
  the default) instead of "NSNumber with nil meaning default".

Fixes #22536
Fixes #22534

Addresses part of #22420
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Apply API review fixes for MTRReadParams and MTRSubscribeParams. (pro…
8be092c 
…ject-chip#22592)

* Move minInterval and maxInterval into MTRSubscribeParams.

* Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to
  the default) instead of "NSNumber with nil meaning default".

Fixes project-chip#22536
Fixes project-chip#22534

Addresses part of project-chip#22420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply API review fixes for MTRReadParams and MTRSubscribeParams. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple