Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review comments on NOC generation Darwin APIs #22197

Closed
bzbarsky-apple opened this issue Aug 26, 2022 · 1 comment
Closed

Address review comments on NOC generation Darwin APIs #22197

bzbarsky-apple opened this issue Aug 26, 2022 · 1 comment
Assignees
@sharadb-amazon @bzbarsky-apple
Labels
darwin V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

See #21705 (review)

Proposed Solution

Address the review comments.
sharadb-amazon added a commit to sharadb-amazon/connectedhomeip that referenced this issue Aug 26, 2022
@sharadb-amazon
Address feedback from project-chip#22197
04dc37a
@bzbarsky-apple bzbarsky-apple mentioned this issue Aug 27, 2022
Merged
chrisdecenzo pushed a commit that referenced this issue Sep 1, 2022
@sharadb-amazon @bzbarsky-apple
Address feedback from #22197 (#22175)
e9984f8 
* Address feedback from #22197

* Allocating and deallocating partialDacVerifier before assignment

* Avoiding returning a BOOL from onNocChainGenerationComplete

* Allocating partialDacVerifier in initWithFactory and checking if allocation failed

* Handling potentially dangling *cppCommissioner, dispatching GetCommissioningParams call on chipWorkQueue

* Update src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@bzbarsky-apple
Copy link
Contributor Author

Fixed in #22175

isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@sharadb-amazon @bzbarsky-apple @isiu-apple
Address feedback from project-chip#22197 (project-chip#22175)
dc8ad94 
* Address feedback from project-chip#22197

* Allocating and deallocating partialDacVerifier before assignment

* Avoiding returning a BOOL from onNocChainGenerationComplete

* Allocating partialDacVerifier in initWithFactory and checking if allocation failed

* Handling potentially dangling *cppCommissioner, dispatching GetCommissioningParams call on chipWorkQueue

* Update src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/darwin/Framework/CHIP/MTROperationalCredentialsDelegate.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharadb-amazon sharadb-amazon

@bzbarsky-apple bzbarsky-apple

Labels
darwin V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sharadb-amazon @woody-apple @bzbarsky-apple