Simplify enum checking in door lock code #20936
Labels
app-clusters
Application cluster work
Comments
|
This is not a must have for v1.0. This clean up will happen post 1.0 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Feb 6, 2023
Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip#20936
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Feb 6, 2023
Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip#20936
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Feb 6, 2023
Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip#20936
bzbarsky-apple
added a commit
that referenced
this issue
Feb 8, 2023
* Simplify and future-proof enum range checks in door locks. Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes #20936 * Address review commment. * Address more review comments.
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this issue
Feb 13, 2023
…hip#24879) * Simplify and future-proof enum range checks in door locks. Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip#20936 * Address review commment. * Address more review comments.
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this issue
Mar 15, 2023
* Simplify and future-proof enum range checks in door locks. Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip/connectedhomeip#20936 * Address review commment. * Address more review comments.
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this issue
Mar 15, 2023
* Simplify and future-proof enum range checks in door locks. Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip/connectedhomeip#20936 * Address review commment. * Address more review comments.
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this issue
Mar 22, 2023
…hip#24879) * Simplify and future-proof enum range checks in door locks. Instead of explicitly checking for the min/max values, check for the "unknown value" value that decoding will decode to if the value is out of range. Fixes project-chip#20936 * Address review commment. * Address more review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are also some places in the door lock (here, here, here, here and here) where we check the range of the enum value. Maybe we can now simplify the checks and just verify the value against corresponding
kUnknownEnumValue?Originally posted by @Morozov-5F in #20907 (comment)
The text was updated successfully, but these errors were encountered: