Skip to content

Ensure that all Fabric-scoped commands respond with UNSUPPORTED_ACCESS if there is no accessing fabric #20811

@bzbarsky-apple

Description

Problem

We have some fabric-scoped commands (e.g. UpdateFabricLabel) that are not following the spec, which says:

if the command in the path is fabric-scoped and there is no accessing fabric, a CommandStatusIB SHALL be generated with the UNSUPPORTED_ACCESS Status Code.

and are returning some other responses instead.

Some of the test plans may in fact be expecting those other responses, hence the cert blocker bit....

Proposed Solution

Audit and fix. The relevant set of commands looks like the following (git grep run in the spec repo):

% git grep "[| ] *F *[ |]" | grep "=>" | sed 's/^[^:]*:\|[^|]*\| *//' | sed 's/ *\|.*//'
AddGroup
ViewGroup
GetGroupMembership
RemoveGroup
RemoveAllGroups
AddGroupIfIdentifying
<<ref_cmd_KeySetWrite>>
<<ref_cmd_KeySetRead>>
<<ref_cmd_KeySetRemove>>
<<ref_cmd_KeySetReadAllIndices>>
CommissioningComplete
UpdateNOC
UpdateFabricLabel

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions