Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pre-SVE] --commissioner-name in chip-tool interactive mode #20151

Closed
HubertHugo opened this issue Jun 30, 2022 · 1 comment · Fixed by #20190
Closed

[Pre-SVE] --commissioner-name in chip-tool interactive mode #20151

HubertHugo opened this issue Jun 30, 2022 · 1 comment · Fixed by #20190
Assignees
@bzbarsky-apple

Comments

@HubertHugo
Copy link
Contributor

SHA: 9b3668c
platform: nRF52840
all-clusters-app
commands:
./chip-tool interactive start
basic read vendor-id 1 0 --commissioner-name alpha
basic read vendor-id 1 0
result in

[1656573028.310987][44752:44757] CHIP:TOO: Sending command to node 0x1
[1656573028.311021][44752:44757] CHIP:TOO: Unknown commissioner name: read. Supported names are [alpha, beta, gamma, 4, 5...]
[1656573028.311031][44752:44757] CHIP:-: chipDie chipDie chipDie
Aborted (core dumped)
@bzbarsky-apple bzbarsky-apple self-assigned this Jun 30, 2022
@bzbarsky-apple
Copy link
Contributor

With ASAN, I don't get the "Unknown commissioner name:" bit, but I do get ASAN errors about heap-use-after-free...

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 30, 2022
@bzbarsky-apple
Clean up optional arguments properly in chip-tool.
f9ccb64 
Otherwise in interactive mode we can end up with noise left over from
a previous command invocation.

Fixes project-chip#20151
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 30, 2022
Merged
bzbarsky-apple added a commit that referenced this issue Jul 1, 2022
@bzbarsky-apple
Clean up optional arguments properly in chip-tool. (#20190)
e491f85 
Otherwise in interactive mode we can end up with noise left over from
a previous command invocation.

Fixes #20151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up optional arguments properly in chip-tool. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @HubertHugo