Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-LVL-7.1]MoveToClosestFrequency is not present in level control XML #19036

Closed
Rajashreekalmane opened this issue Jun 1, 2022 · 5 comments · Fixed by #19065
Closed

[TC-LVL-7.1]MoveToClosestFrequency is not present in level control XML #19036

Rajashreekalmane opened this issue Jun 1, 2022 · 5 comments · Fixed by #19065
Assignees

Comments

@Rajashreekalmane
Copy link

Problem

chip-tool needs to implement mandatory MoveToClosestFrequency command.

System configuration:-
Chip-tool - RPI-4, 8GB RAM
DUT - RPI - RPI-4, 8GB RAM
Platform : IP and wifi
Commit-ID:4d84a4a978ffc867a62b9b15423a9b70d9cb993e
Dut application: all-clusters-app

PFA screenshot below:-
image

Test-plan reference:-
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/levelcontrol.adoc#tc-lvl-7-1-verification-of-movetoclosestfrequency-command-dut-as-server

Spec reference:-
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/LevelControl.adoc#ref_sec_3_10_3_2

@bzbarsky-apple
Copy link
Contributor

This is not a chip-tool issue per se; the command is missing from the XML.

It's also not mandatory, but we clearly do need to add it.

@bzbarsky-apple bzbarsky-apple changed the title [TC-LVL-7.1]--chip-tool needs to implement mandatory MoveToClosestFrequency command. [TC-LVL-7.1]MoveToClosestFrequency is not present in level control XML Jun 1, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 1, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 2, 2022
@raju-apple raju-apple reopened this Jun 8, 2022
@sankarselvam
Copy link

@bzbarsky-apple Rajashree is still not able to see the "MoveToClosestFrequency" in the Chip-tool command options. Hence we re-opened this issue for the follow-up.
Can you please check the commit & give us some clarifications?

@bzbarsky-apple
Copy link
Contributor

is still not able to see the "MoveToClosestFrequency" in the Chip-tool command options

Using what SHA? Using what steps? @raju-apple @sankarselvam @Rajashreekalmane please actually provide relevant information when reporting problems; otherwise a lot of time gets wasted.

Concretely, on 5362125 I see

% ./out/debug/standalone/chip-tool levelcontrol |& grep move-to-closest
  | * move-to-closest-frequency        

as expected.

@sankarselvam
Copy link

@Rajashreekalmane Can you please share the SHA you used?

@Rajashreekalmane
Copy link
Author

When it was tried in another setup, it worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants