Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-DD-3.1] Need to print different stages of commissioning flow in the log file as we cant verify all the commissioning flow in the current log file after provision is done #16096

Closed
sowmyassp opened this issue Mar 11, 2022 · 8 comments
Labels
cert spec Mismatch between spec and implementation V1.0

Comments

@sowmyassp
Copy link

sowmyassp commented Mar 11, 2022

@bzbarsky-apple
Copy link
Contributor

@sowmyassp does #14736 address this?

@sowmyassp
Copy link
Author

@bzbarsky-apple yes, this ticket addresses the issue

@bzbarsky-apple
Copy link
Contributor

Please close if resolved?

@sowmyassp
Copy link
Author

No its not yet resolved, for these [TC-DD-3.1], [TC-DD-3.2], [TC-DD-3.5], [TC-DD-3.6] test-cases we need commissioning flow such as "Commissioner configures Fabric information", "Commissioner requests operational CSR" which is needed to verify this test-cases.

@sowmyassp sowmyassp changed the title [TC-DD-3.1] Need to print different stages of pairing in the log file as we cant verify all the commissiong flow in the current lof file [TC-DD-3.1] Need to print different stages of commissioning flow in the log file as we cant verify all the commissioning flow in the current log file after provision is done Apr 13, 2022
@andy31415
Copy link
Contributor

@sowmyassp - could you describe the reason and use of this printout (likely subset of the actual test case description)?

Release builds of devices (such as devices being certified) would not get access to logs so having tests rely on logs and their content does not seem the best way, however I am not convinced we have an ideal way either. Is there a requirement for certified devices to have logging enabled? How about tiny devices that cannot even have logging (e.g. qpg devices had logging disabled to use less flash).

@cjandhyala
Copy link
Contributor

@andy31415 The log lines requested are on the TH side but not DUT. TCs like https://github.com/CHIP-Specifications/chip-test-plans/blob/3bcd71e5bf2fe7ce7b143614f9b0ee89c9af2b16/src/devicediscovery.adoc#335-tc-dd-35-commissioning-flow---concurrent-dut---commissioner , require to verify every step of the commissioning flow. The only we can do that is by verifying the log lines in the TH to see if DUT finished all those intermediate steps in the commissioning flow. Alternatively we need to think, do we need to verify all those intermediate steps of commissioning flow as part of certification test case OR just verify if the device can be provisioned successfully or not ?

@franck-apple franck-apple added V1.0 spec Mismatch between spec and implementation cert labels May 12, 2022
@sowmyassp
Copy link
Author

Test-plan is updated with correct commissioning flow and we are getting the same in logs

@sowmyassp
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cert spec Mismatch between spec and implementation V1.0
Projects
None yet
Development

No branches or pull requests

5 participants