Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more prints to AutoCommissioner/CASESessionManager #14736

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Add more prints to AutoCommissioner/CASESessionManager #14736

merged 7 commits into from
Mar 17, 2022

Conversation

mrjerryjohns
Copy link
Contributor

This not only provides more insights into the mechanics of the
commissioning state machinery but the state transitions with the
controller-side CASE session machinery. This is needed to debug some
hairy race conditions when commissioning onto multiple fabrics.

@woody-apple @msandstedt
Update src/app/OperationalDeviceProxy.cpp
171b873 
Co-authored-by: Michael Sandstedt <michael.sandstedt@gmail.com>
@stale
Copy link

stale bot commented Feb 15, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Feb 15, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Feb 16, 2022
@pullapprove pullapprove bot requested a review from lazarkov February 18, 2022 18:07
@stale
Copy link

stale bot commented Feb 25, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Feb 25, 2022
@stale
Copy link

stale bot commented Mar 5, 2022

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale bot closed this Mar 5, 2022
@bzbarsky-apple bzbarsky-apple reopened this Mar 8, 2022
@stale stale bot removed the stale Stale issue or PR label Mar 8, 2022
@restyled-io restyled-io bot mentioned this pull request Mar 10, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 10, 2022 •
edited
Loading

PR #14736: Size comparison from 190520d to 7b5634c

Increases above 0.2%:

platform target config section 190520d 7b5634c change % change
linux chip-tool debug .init_array 616 624 8 1.3
tv-app debug .init_array 880 888 8 0.9
.rodata 199293 200061 768 0.4
Increases (15 builds for cyw30739, linux, telink)
platform target config section 190520d 7b5634c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598058 598186 128 0.0
.app_xip_area 505640 505768 128 0.0
lock cyw930739m2evb_01 (read/write) 555926 556058 132 0.0
.app_xip_area 465044 465176 132 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566030 566074 44 0.0
.app_xip_area 465444 465488 44 0.0
linux all-clusters-app debug (read only) 2430321 2431201 880 0.0
.rodata 205637 205893 256 0.1
.text 2061698 2062322 624 0.0
bridge-app debug+rpc (read only) 1735493 1736181 688 0.0
.rodata 141868 142092 224 0.2
.text 1477653 1478117 464 0.0
chip-tool debug (read only) 10093045 10095021 1976 0.0
(read/write) 358168 358176 8 0.0
.init_array 616 624 8 1.3
.rodata 514196 514964 768 0.1
.text 8796165 8797349 1184 0.0
chip-tool-ipv6only arm64 (read only) 9729052 9730868 1816 0.0
.rodata 491908 492572 664 0.1
.text 8185956 8187108 1152 0.0
door-lock-app debug (read only) 1949953 1950625 672 0.0
.rodata 173756 173980 224 0.1
.text 1627554 1628002 448 0.0
lighting-app debug+rpc (read only) 2082121 2082825 704 0.0
.rodata 165948 166204 256 0.2
.text 1760514 1760962 448 0.0
ota-provider-app debug (read only) 1883193 1883865 672 0.0
.rodata 158963 159187 224 0.1
.text 1573506 1573954 448 0.0
ota-requestor-app debug (read only) 1910801 1911681 880 0.0
.rodata 154924 155180 256 0.2
.text 1605362 1605986 624 0.0
shell debug (read only) 2396513 2397393 880 0.0
.rodata 205586 205842 256 0.1
.text 2034354 2034978 624 0.0
thermostat-no-ble arm64 (read only) 2178620 2179388 768 0.0
.rodata 133116 133340 224 0.2
.text 1826912 1827456 544 0.0
tv-app debug (read only) 2622009 2624001 1992 0.1
(read/write) 250360 250368 8 0.0
.init_array 880 888 8 0.9
.rodata 199293 200061 768 0.4
.text 2248626 2249826 1200 0.1
telink lighting-app tlsr9518adk80d (read/write) 888882 889226 344 0.0
text 628184 628322 138 0.0
Full report (15 builds for cyw30739, linux, telink)
platform target config section 190520d 7b5634c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598058 598186 128 0.0
.app_xip_area 505640 505768 128 0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555926 556058 132 0.0
.app_xip_area 465044 465176 132 0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566030 566074 44 0.0
.app_xip_area 465444 465488 44 0.0
.bss 82996 82996 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux all-clusters-app debug (read only) 2430321 2431201 880 0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205637 205893 256 0.1
.text 2061698 2062322 624 0.0
bridge-app debug+rpc (read only) 1735493 1736181 688 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141868 142092 224 0.2
.text 1477653 1478117 464 0.0
chip-tool debug (read only) 10093045 10095021 1976 0.0
(read/write) 358168 358176 8 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 325352 325352 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 624 8 1.3
.rodata 514196 514964 768 0.1
.text 8796165 8797349 1184 0.0
chip-tool-ipv6only arm64 (read only) 9729052 9730868 1816 0.0
(read/write) 475969 475969 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371712 371712 0 0.0
.dynamic 560 560 0 0.0
.got 55304 55304 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 491908 492572 664 0.1
.text 8185956 8187108 1152 0.0
door-lock-app debug (read only) 1949953 1950625 672 0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173756 173980 224 0.1
.text 1627554 1628002 448 0.0
lighting-app debug+rpc (read only) 2082121 2082825 704 0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 165948 166204 256 0.2
.text 1760514 1760962 448 0.0
ota-provider-app debug (read only) 1883193 1883865 672 0.0
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158963 159187 224 0.1
.text 1573506 1573954 448 0.0
ota-requestor-app debug (read only) 1910801 1911681 880 0.0
(read/write) 117864 117864 0 0.0
.bss 51584 51584 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59368 59368 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154924 155180 256 0.2
.text 1605362 1605986 624 0.0
shell debug (read only) 2396513 2397393 880 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205586 205842 256 0.1
.text 2034354 2034978 624 0.0
thermostat-no-ble arm64 (read only) 2178620 2179388 768 0.0
(read/write) 148817 148817 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133116 133340 224 0.2
.text 1826912 1827456 544 0.0
tv-app debug (read only) 2622009 2624001 1992 0.1
(read/write) 250360 250368 8 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 888 8 0.9
.rodata 199293 200061 768 0.4
.text 2248626 2249826 1200 0.1
telink lighting-app tlsr9518adk80d (read/write) 888882 889226 344 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628184 628322 138 0.0

@github-actions
Copy link

github-actions bot commented Mar 10, 2022 •
edited
Loading

PR #14736: Size comparison from b5a0754 to 21fd3d9

Increases above 0.2%:

platform target config section b5a0754 21fd3d9 change % change
linux chip-tool debug .init_array 616 624 8 1.3
tv-app debug .init_array 880 888 8 0.9
.rodata 199453 200285 832 0.4
Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section b5a0754 21fd3d9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598154 598282 128 0.0
.app_xip_area 505736 505864 128 0.0
lock cyw930739m2evb_01 (read/write) 556030 556162 132 0.0
.app_xip_area 465148 465280 132 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566014 566058 44 0.0
.app_xip_area 465428 465472 44 0.0
efr32 lighting-app BRD4161A (read only) 919968 920376 408 0.0
.text 919960 920368 408 0.0
BRD4161A+rpc (read only) 948796 949204 408 0.0
.text 948788 949196 408 0.0
window-app BRD4161A (read only) 852444 852672 228 0.0
(read/write) 126220 126224 4 0.0
.text 852436 852664 228 0.0
esp32 all-clusters-app c3devkit (read only) 957700 957902 202 0.0
(read/write) 1393874 1394122 248 0.0
.flash.rodata 197160 197408 248 0.1
.flash.text 957700 957902 202 0.0
m5stack (read only) 1012895 1013083 188 0.0
(read/write) 461108 461348 240 0.1
.flash.rodata 226112 226352 240 0.1
.flash.text 1007511 1007699 188 0.0
k32w light k32w061+release (read/write) 694600 695008 408 0.1
.text 609716 610124 408 0.1
lock k32w061+release (read/write) 695384 695628 244 0.0
.text 610548 610792 244 0.0
linux all-clusters-app debug (read only) 2430609 2431457 848 0.0
.rodata 205861 206085 224 0.1
.text 2061762 2062386 624 0.0
bridge-app debug+rpc (read only) 1735717 1736421 704 0.0
.rodata 142028 142284 256 0.2
.text 1477717 1478165 448 0.0
chip-tool debug (read only) 10093413 10095389 1976 0.0
(read/write) 358168 358176 8 0.0
.init_array 616 624 8 1.3
.rodata 514388 515156 768 0.1
.text 8796341 8797525 1184 0.0
chip-tool-ipv6only arm64 (read only) 9729324 9731156 1832 0.0
.rodata 492084 492748 664 0.1
.text 8186052 8187220 1168 0.0
door-lock-app debug (read only) 1950193 1950913 720 0.0
.rodata 173948 174204 256 0.1
.text 1627602 1628066 464 0.0
lighting-app debug+rpc (read only) 2082361 2083113 752 0.0
.rodata 166140 166428 288 0.2
.text 1760562 1761026 464 0.0
ota-provider-app debug (read only) 1883609 1884313 704 0.0
.rodata 159155 159411 256 0.2
.text 1573730 1574178 448 0.0
ota-requestor-app debug (read only) 1911073 1911921 848 0.0
.rodata 155148 155372 224 0.1
.text 1605410 1606034 624 0.0
shell debug (read only) 2396785 2397633 848 0.0
.rodata 205810 206034 224 0.1
.text 2034402 2035026 624 0.0
thermostat-no-ble arm64 (read only) 2178780 2179548 768 0.0
.rodata 133196 133420 224 0.2
.text 1826992 1827536 544 0.0
tv-app debug (read only) 2622297 2624337 2040 0.1
(read/write) 250360 250368 8 0.0
.init_array 880 888 8 0.9
.rodata 199453 200285 832 0.4
.text 2248754 2249938 1184 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2351540 2351788 248 0.0
.text 1314140 1314388 248 0.0
p6 all-clusters-app default (read/write) 2494312 2494736 424 0.0
.text 1452576 1453000 424 0.0
light-app default (read/write) 2398392 2398640 248 0.0
.text 1356656 1356904 248 0.0
lock-app default (read/write) 2361952 2362200 248 0.0
.text 1320216 1320464 248 0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 889282 336 0.0
text 628166 628304 138 0.0
Full report (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section b5a0754 21fd3d9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598154 598282 128 0.0
.app_xip_area 505736 505864 128 0.0
.bss 75108 75108 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556030 556162 132 0.0
.app_xip_area 465148 465280 132 0.0
.bss 73612 73612 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566014 566058 44 0.0
.app_xip_area 465428 465472 44 0.0
.bss 82996 82996 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 919968 920376 408 0.0
(read/write) 128264 128264 0 0.0
.bss 126224 126224 0 0.0
.data 2040 2040 0 0.0
.text 919960 920368 408 0.0
BRD4161A+rpc (read only) 948796 949204 408 0.0
(read/write) 144220 144220 0 0.0
.bss 142000 142000 0 0.0
.data 2220 2220 0 0.0
.text 948788 949196 408 0.0
window-app BRD4161A (read only) 852444 852672 228 0.0
(read/write) 126220 126224 4 0.0
.bss 124304 124304 0 0.0
.data 1916 1916 0 0.0
.text 852436 852664 228 0.0
esp32 all-clusters-app c3devkit (read only) 957700 957902 202 0.0
(read/write) 1393874 1394122 248 0.0
.dram0.bss 63576 63576 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 197160 197408 248 0.1
.flash.text 957700 957902 202 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012895 1013083 188 0.0
(read/write) 461108 461348 240 0.1
.dram0.bss 69096 69096 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226112 226352 240 0.1
.flash.text 1007511 1007699 188 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694600 695008 408 0.1
.bss 77160 77160 0 0.0
.data 1924 1924 0 0.0
.text 609716 610124 408 0.1
lock k32w061+release (read/write) 695384 695628 244 0.0
.bss 77072 77072 0 0.0
.data 1964 1964 0 0.0
.text 610548 610792 244 0.0
linux all-clusters-app debug (read only) 2430609 2431457 848 0.0
(read/write) 145872 145872 0 0.0
.bss 60352 60352 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78424 78424 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 205861 206085 224 0.1
.text 2061762 2062386 624 0.0
bridge-app debug+rpc (read only) 1735717 1736421 704 0.0
(read/write) 92784 92784 0 0.0
.bss 47624 47624 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 38064 38064 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 142028 142284 256 0.2
.text 1477717 1478165 448 0.0
chip-tool debug (read only) 10093413 10095389 1976 0.0
(read/write) 358168 358176 8 0.0
.bss 25640 25640 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 325352 325352 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 624 8 1.3
.rodata 514388 515156 768 0.1
.text 8796341 8797525 1184 0.0
chip-tool-ipv6only arm64 (read only) 9729324 9731156 1832 0.0
(read/write) 475969 475969 0 0.0
.bss 43953 43953 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 371712 371712 0 0.0
.dynamic 560 560 0 0.0
.got 55304 55304 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 492084 492748 664 0.1
.text 8186052 8187220 1168 0.0
door-lock-app debug (read only) 1950193 1950913 720 0.0
(read/write) 119296 119296 0 0.0
.bss 50656 50656 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173948 174204 256 0.1
.text 1627602 1628066 464 0.0
lighting-app debug+rpc (read only) 2082361 2083113 752 0.0
(read/write) 124616 124616 0 0.0
.bss 51456 51456 0 0.0
.data 1536 1536 0 0.0
.data.rel.ro 66104 66104 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 166140 166428 288 0.2
.text 1760562 1761026 464 0.0
ota-provider-app debug (read only) 1883609 1884313 704 0.0
(read/write) 114896 114896 0 0.0
.bss 50464 50464 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 57464 57464 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 159155 159411 256 0.2
.text 1573730 1574178 448 0.0
ota-requestor-app debug (read only) 1911073 1911921 848 0.0
(read/write) 117864 117864 0 0.0
.bss 51584 51584 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 59368 59368 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 155148 155372 224 0.1
.text 1605410 1606034 624 0.0
shell debug (read only) 2396785 2397633 848 0.0
(read/write) 150088 150088 0 0.0
.bss 70472 70472 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73064 73064 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205810 206034 224 0.1
.text 2034402 2035026 624 0.0
thermostat-no-ble arm64 (read only) 2178780 2179548 768 0.0
(read/write) 148817 148817 0 0.0
.bss 65393 65393 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 560 560 0 0.0
.got 4240 4240 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133196 133420 224 0.2
.text 1826992 1827536 544 0.0
tv-app debug (read only) 2622297 2624337 2040 0.1
(read/write) 250360 250368 8 0.0
.bss 167520 167520 0 0.0
.data 3168 3168 0 0.0
.data.rel.ro 73624 73624 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 888 8 0.9
.rodata 199453 200285 832 0.4
.text 2248754 2249938 1184 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2351540 2351788 248 0.0
.bss 186212 186212 0 0.0
.data 5792 5792 0 0.0
.text 1314140 1314388 248 0.0
p6 all-clusters-app default (read/write) 2494312 2494736 424 0.0
.bss 119640 119640 0 0.0
.data 2680 2680 0 0.0
.text 1452576 1453000 424 0.0
light-app default (read/write) 2398392 2398640 248 0.0
.bss 113104 113104 0 0.0
.data 2536 2536 0 0.0
.text 1356656 1356904 248 0.0
lock-app default (read/write) 2361952 2362200 248 0.0
.bss 112848 112848 0 0.0
.data 2496 2496 0 0.0
.text 1320216 1320464 248 0.0
telink lighting-app tlsr9518adk80d (read/write) 888946 889282 336 0.0
bss 86968 86968 0 0.0
noinit 37160 37160 0 0.0
text 628166 628304 138 0.0

@bzbarsky-apple bzbarsky-apple mentioned this pull request Mar 11, 2022
Closed
@mrjerryjohns mrjerryjohns merged commit c4d81c8 into project-chip:master Mar 17, 2022
ArekBalysNordic pushed a commit to ArekBalysNordic/connectedhomeip that referenced this pull request Mar 18, 2022
@mrjerryjohns @woody-apple
@msandstedt @ArekBalysNordic
Add more prints to AutoCommissioner/CASESessionManager (project-chip#…
6eaed70 
…14736)

* Add more prints to AutoCommissioner/CASESessionManager

This not only provides more insights into the mechanics of the
commissioning state machinery but the state transitions with the
controller-side CASE session machinery. This is needed to debug some
hairy race conditions when commissioning onto multiple fabrics.

* Update src/app/OperationalDeviceProxy.cpp

Co-authored-by: Michael Sandstedt <michael.sandstedt@gmail.com>

* Review feedback + some more prints.

* Minor fixups.

* Missed a file

Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Michael Sandstedt <michael.sandstedt@gmail.com>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@mrjerryjohns @woody-apple
@msandstedt @andrei-menzopol
Add more prints to AutoCommissioner/CASESessionManager (project-chip#…
bf1562c 
…14736)

* Add more prints to AutoCommissioner/CASESessionManager

This not only provides more insights into the mechanics of the
commissioning state machinery but the state transitions with the
controller-side CASE session machinery. This is needed to debug some
hairy race conditions when commissioning onto multiple fabrics.

* Update src/app/OperationalDeviceProxy.cpp

Co-authored-by: Michael Sandstedt <michael.sandstedt@gmail.com>

* Review feedback + some more prints.

* Minor fixups.

* Missed a file

Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Michael Sandstedt <michael.sandstedt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt left review comments

@cecille cecille cecille left review comments

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@lazarkov lazarkov Awaiting requested review from lazarkov

Assignees
No one assigned
Labels
app controller lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mrjerryjohns @tcarmelveilleux @msandstedt @cecille @bzbarsky-apple @woody-apple