Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_suite so access control is off or ACLs are installed #14985

Closed
mlepage-google opened this issue Feb 9, 2022 · 3 comments
Closed

Fix test_suite so access control is off or ACLs are installed #14985

mlepage-google opened this issue Feb 9, 2022 · 3 comments
Labels
acl Access Control feature testing V1.0

Comments

@mlepage-google
Copy link
Contributor

Operations in test_suite will fail once Access Control is enforced (issue #14454) so either "real" access control can't be enabled for the test suite, or the test suite needs to install ACLs so the test operations pass, or some combination of both (as appropriate).
@mlepage-google
Copy link
Contributor Author

I don't know enough about how the test suite is set up and run and what is being tested to have an opinion on disable access control vs. install ACLs.

@mlepage-google mlepage-google added acl Access Control feature V1.0 testing labels Feb 9, 2022
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Feb 14, 2022
@mlepage-google
Install ACL for group messaging test
e028142 
Group messaging test will of course fail without an installed ACL
that permits the tested IM operations via group auth mode.

Install an ACL during the test so it can succeed.

Also, complete the work to transcode Group and PASE subjects from
the cluster level (not encoded in a NodeId) to the system level
(encoded in a NodeId).

Part of project-chip#14985
@mlepage-google mlepage-google mentioned this issue Feb 14, 2022
Merged
mlepage-google added a commit that referenced this issue Feb 15, 2022
@mlepage-google
Install ACL for group messaging test (#15158)
6ad78e2 
* Install ACL for group messaging test

Group messaging test will of course fail without an installed ACL
that permits the tested IM operations via group auth mode.

Install an ACL during the test so it can succeed.

Also, complete the work to transcode Group and PASE subjects from
the cluster level (not encoded in a NodeId) to the system level
(encoded in a NodeId).

Part of #14985
@mlepage-google
Copy link
Contributor Author

FYI I went through most of the tests today and didn't see others that need fixing, but I'm waiting for CI to confirm, as I do have some hangs when running so it's difficult to be certain.

@mlepage-google
Copy link
Contributor Author

Redux on this one:

  • spent about a week fixing tests (unit tests and YAML tests)
  • and also adding a YAML test for access control cluster (already have unit tests for system module)
  • discovered several glitches with the test system, YAML, codegen etc. which got resolved
  • tweaked logging so it appears on more devices/setups (not all have "detail" level)
  • added ACL to some test setups (e.g. group messaging YAML tests) so they could succeed
  • refactored some testing configuration so it uses a "permissive" access control (if it is testing other things)
  • and so that setup doesn't share/bleed from one test suite to another (an issue on some platforms/setups)

jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this issue Apr 26, 2022
@mlepage-google @fuxingguo16
Install ACL for group messaging test (project-chip#15158)
2adf23f 
* Install ACL for group messaging test

Group messaging test will of course fail without an installed ACL
that permits the tested IM operations via group auth mode.

Install an ACL during the test so it can succeed.

Also, complete the work to transcode Group and PASE subjects from
the cluster level (not encoded in a NodeId) to the system level
(encoded in a NodeId).

Part of project-chip#14985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acl Access Control feature testing V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mlepage-google