Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PasscodeId type where appropriate #14439

Closed
mlepage-google opened this issue Jan 27, 2022 · 2 comments
Closed

Use PasscodeId type where appropriate #14439

mlepage-google opened this issue Jan 27, 2022 · 2 comments
Assignees
@mlepage-google
Labels
acl Access Control feature V1.0

Comments

@mlepage-google
Copy link
Contributor

mlepage-google commented Jan 27, 2022 •
edited
Loading

Had been using raw uint16_t in places in SDK, but there was added a PasscodeId type in PasscodeId.h, so switch to using that where appropriate.
@mlepage-google mlepage-google added acl Access Control feature V1.0 labels Jan 27, 2022
@andy31415 andy31415 added v1_triage_split_3 V1.0 acl Access Control feature and removed V1.0 acl Access Control feature labels Jan 30, 2022
@mlepage-google mlepage-google self-assigned this Jan 31, 2022
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Feb 9, 2022
@mlepage-google
Use PasscodeId in NodeId functions
0b958df 
Instead of underlying uint16_t type.

Part of issue project-chip#14439
@mlepage-google mlepage-google mentioned this issue Feb 9, 2022
Merged
@mlepage-google
Copy link
Contributor Author

@emargolis did most of this in PR #14799
PR #14960 just gets a few of the conversion functions in NodeId.h
and I think that's the last of them.

woody-apple pushed a commit that referenced this issue Feb 9, 2022
@mlepage-google
Use PasscodeId in NodeId functions (#14960)
21aa882 
Instead of underlying uint16_t type.

Part of issue #14439
@mlepage-google
Copy link
Contributor Author

All done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlepage-google mlepage-google

Labels
acl Access Control feature V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tcarmelveilleux @andy31415 @mlepage-google