Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter to Objective-C CHIPDeviceController to accept PAA certificates from Objective-C client #14126

Closed
woody-apple opened this issue Jan 25, 2022 · 0 comments · Fixed by #17035
Closed

Add parameter to Objective-C CHIPDeviceController to accept PAA certificates from Objective-C client #14126

woody-apple opened this issue Jan 25, 2022 · 0 comments · Fixed by #17035
Assignees
@vijs @woody-apple
Labels
attestation darwin tcv-dri-triage-temp todo 🗒️ V1.0

Comments

@woody-apple
Copy link
Contributor

woody-apple commented Jan 25, 2022 •
edited
Loading

Replace testingRootStore with a AttestationTrustStore that has the necessary official PAA roots availab

connectedhomeip/src/darwin/Framework/CHIP/CHIPDeviceController.mm

Lines 194 to 199 in f0f5de0

// TODO: Replace testingRootStore with a AttestationTrustStore that has the necessary official PAA roots available
const chip::Credentials::AttestationTrustStore * testingRootStore = chip::Credentials::GetTestAttestationTrustStore();
chip::Credentials::SetDeviceAttestationVerifier(chip::Credentials::GetDefaultDACVerifier(testingRootStore));
params.fabricStorage = _fabricStorage;
commissionerParams.storageDelegate = _persistentStorageDelegateBridge;

This issue was generated by todo-issue based on a TODO comment in f0f5de0.
@woody-apple woody-apple mentioned this issue Mar 25, 2022
Closed
@woody-apple woody-apple self-assigned this Mar 25, 2022
@woody-apple woody-apple changed the title Replace testingRootStore with a AttestationTrustStore that has the necessary official PAA roots available Add parameter to Objective-C CHIPDeviceController to accept PAA certificates from Objective-C client #16684 Mar 25, 2022
@woody-apple woody-apple changed the title Add parameter to Objective-C CHIPDeviceController to accept PAA certificates from Objective-C client #16684 Add parameter to Objective-C CHIPDeviceController to accept PAA certificates from Objective-C client Mar 25, 2022
@carricdsilva-apple carricdsilva-apple mentioned this issue Mar 29, 2022
Closed
carricdsilva-apple added a commit to carricdsilva-apple/connectedhomeip that referenced this issue Apr 5, 2022
@carricdsilva-apple
Added parameter to Objective-C CHIPDeviceController to accept PAA cer…
ace43bd 
…tificates from Objective-C client

Fixes project-chip#14126

Change overview

Added a new parameter to CHIPDeviceController that is an array of NSData PAA certificates.
Created an Objective-C bridge for the AttestationTrustStore class. The PAA certificates provided
by the client are passed to the default device attestation verifier. If the client passes a nil
value for the parameter then the testing root store is used.

Testing

Used an Objective-C client to pass valid certificates to ensure device attestation procedure
succeeded with an m5stack device. Passed in nil to ensure the device attestation procedure used
the test PAA certificates.
@carricdsilva-apple carricdsilva-apple mentioned this issue Apr 5, 2022
Merged
carricdsilva-apple added a commit to carricdsilva-apple/connectedhomeip that referenced this issue Apr 5, 2022
@carricdsilva-apple
Added parameter to Objective-C CHIPDeviceController to accept PAA cer…
fba323a 
…tificates from Objective-C client

Fixes project-chip#14126

Change overview

Added a new parameter to CHIPDeviceController that is an array of NSData PAA certificates.
Created an Objective-C bridge for the AttestationTrustStore class. The PAA certificates provided
by the client are passed to the default device attestation verifier. If the client passes a nil
value for the parameter then the testing root store is used.

Testing

Used an Objective-C client to pass valid certificates to ensure device attestation procedure
succeeded with an m5stack device. Passed in nil to ensure the device attestation procedure used
the test PAA certificates.
woody-apple pushed a commit to carricdsilva-apple/connectedhomeip that referenced this issue Apr 5, 2022
@carricdsilva-apple @woody-apple
Added parameter to Objective-C CHIPDeviceController to accept PAA cer…
692098d 
…tificates from Objective-C client

Fixes project-chip#14126

Change overview

Added a new parameter to CHIPDeviceController that is an array of NSData PAA certificates.
Created an Objective-C bridge for the AttestationTrustStore class. The PAA certificates provided
by the client are passed to the default device attestation verifier. If the client passes a nil
value for the parameter then the testing root store is used.

Testing

Used an Objective-C client to pass valid certificates to ensure device attestation procedure
succeeded with an m5stack device. Passed in nil to ensure the device attestation procedure used
the test PAA certificates.
woody-apple pushed a commit to carricdsilva-apple/connectedhomeip that referenced this issue Apr 5, 2022
@carricdsilva-apple @bzbarsky-apple
Added parameter to Objective-C CHIPDeviceController to accept PAA cer…
8f22b6a 
…tificates from Objective-C client

Fixes project-chip#14126

Change overview

Added a new parameter to CHIPDeviceController that is an array of NSData PAA certificates.
Created an Objective-C bridge for the AttestationTrustStore class. The PAA certificates provided
by the client are passed to the default device attestation verifier. If the client passes a nil
value for the parameter then the testing root store is used.

Testing

Used an Objective-C client to pass valid certificates to ensure device attestation procedure
succeeded with an m5stack device. Passed in nil to ensure the device attestation procedure used
the test PAA certificates.
woody-apple added a commit that referenced this issue Apr 6, 2022
@carricdsilva-apple @restyled-commits
@woody-apple @bzbarsky-apple
Added parameter to Objective-C CHIPDeviceController to accept PAA cer… (
be4356b 
#17035)

* Added parameter to Objective-C CHIPDeviceController to accept PAA certificates from Objective-C client

Fixes #14126

Change overview

Added a new parameter to CHIPDeviceController that is an array of NSData PAA certificates.
Created an Objective-C bridge for the AttestationTrustStore class. The PAA certificates provided
by the client are passed to the default device attestation verifier. If the client passes a nil
value for the parameter then the testing root store is used.

Testing

Used an Objective-C client to pass valid certificates to ensure device attestation procedure
succeeded with an m5stack device. Passed in nil to ensure the device attestation procedure used
the test PAA certificates.

* Restyled by whitespace

* Restyled by clang-format

* Update src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Updated files:
examples/chip-tool-darwin/commands/common/CHIPCommandBridge.mm
src/darwin/CHIPTool/CHIPTool/Framework Helpers/DefaultsUtils.m
src/darwin/Framework/CHIP/BUILD.gn
src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm
src/darwin/Framework/CHIP/CHIPDeviceController.h
src/darwin/Framework/CHIP/CHIPDeviceController.mm

* Restyled by gn

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
chencheung pushed a commit to chencheung/connectedhomeip that referenced this issue Apr 6, 2022
@carricdsilva-apple @restyled-commits
@woody-apple @bzbarsky-apple @chencheung
Added parameter to Objective-C CHIPDeviceController to accept PAA cer… (
cac3451 
project-chip#17035)

* Added parameter to Objective-C CHIPDeviceController to accept PAA certificates from Objective-C client

Fixes project-chip#14126

Change overview

Added a new parameter to CHIPDeviceController that is an array of NSData PAA certificates.
Created an Objective-C bridge for the AttestationTrustStore class. The PAA certificates provided
by the client are passed to the default device attestation verifier. If the client passes a nil
value for the parameter then the testing root store is used.

Testing

Used an Objective-C client to pass valid certificates to ensure device attestation procedure
succeeded with an m5stack device. Passed in nil to ensure the device attestation procedure used
the test PAA certificates.

* Restyled by whitespace

* Restyled by clang-format

* Update src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Updated files:
examples/chip-tool-darwin/commands/common/CHIPCommandBridge.mm
src/darwin/CHIPTool/CHIPTool/Framework Helpers/DefaultsUtils.m
src/darwin/Framework/CHIP/BUILD.gn
src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm
src/darwin/Framework/CHIP/CHIPDeviceController.h
src/darwin/Framework/CHIP/CHIPDeviceController.mm

* Restyled by gn

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
chencheung pushed a commit to chencheung/connectedhomeip that referenced this issue Apr 6, 2022
@carricdsilva-apple @restyled-commits
@woody-apple @bzbarsky-apple @chencheung
Added parameter to Objective-C CHIPDeviceController to accept PAA cer… (
2afa53c 
project-chip#17035)

* Added parameter to Objective-C CHIPDeviceController to accept PAA certificates from Objective-C client

Fixes project-chip#14126

Change overview

Added a new parameter to CHIPDeviceController that is an array of NSData PAA certificates.
Created an Objective-C bridge for the AttestationTrustStore class. The PAA certificates provided
by the client are passed to the default device attestation verifier. If the client passes a nil
value for the parameter then the testing root store is used.

Testing

Used an Objective-C client to pass valid certificates to ensure device attestation procedure
succeeded with an m5stack device. Passed in nil to ensure the device attestation procedure used
the test PAA certificates.

* Restyled by whitespace

* Restyled by clang-format

* Update src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Updated files:
examples/chip-tool-darwin/commands/common/CHIPCommandBridge.mm
src/darwin/CHIPTool/CHIPTool/Framework Helpers/DefaultsUtils.m
src/darwin/Framework/CHIP/BUILD.gn
src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm
src/darwin/Framework/CHIP/CHIPDeviceController.h
src/darwin/Framework/CHIP/CHIPDeviceController.mm

* Restyled by gn

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this issue Apr 14, 2022
@carricdsilva-apple @restyled-commits
@woody-apple @bzbarsky-apple @andrei-menzopol
Added parameter to Objective-C CHIPDeviceController to accept PAA cer… (
90c567b 
project-chip#17035)

* Added parameter to Objective-C CHIPDeviceController to accept PAA certificates from Objective-C client

Fixes project-chip#14126

Change overview

Added a new parameter to CHIPDeviceController that is an array of NSData PAA certificates.
Created an Objective-C bridge for the AttestationTrustStore class. The PAA certificates provided
by the client are passed to the default device attestation verifier. If the client passes a nil
value for the parameter then the testing root store is used.

Testing

Used an Objective-C client to pass valid certificates to ensure device attestation procedure
succeeded with an m5stack device. Passed in nil to ensure the device attestation procedure used
the test PAA certificates.

* Restyled by whitespace

* Restyled by clang-format

* Update src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Updated files:
examples/chip-tool-darwin/commands/common/CHIPCommandBridge.mm
src/darwin/CHIPTool/CHIPTool/Framework Helpers/DefaultsUtils.m
src/darwin/Framework/CHIP/BUILD.gn
src/darwin/Framework/CHIP/CHIPAttestationTrustStoreBridge.mm
src/darwin/Framework/CHIP/CHIPDeviceController.h
src/darwin/Framework/CHIP/CHIPDeviceController.mm

* Restyled by gn

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vijs vijs

@woody-apple woody-apple

Labels
attestation darwin tcv-dri-triage-temp todo 🗒️ V1.0
Projects
None yet
Milestone
No milestone
4 participants
@tcarmelveilleux @andy31415 @vijs @woody-apple