Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectPool leaks in GroupDataProviderImpl #12503

Closed
kpschoedel opened this issue Dec 2, 2021 · 1 comment
Closed

ObjectPool leaks in GroupDataProviderImpl #12503

kpschoedel opened this issue Dec 2, 2021 · 1 comment
Labels
leak Memory leak bug

Comments

@kpschoedel
Copy link
Contributor

Problem

GroupDataProviderImpl::mKeySetIterators had live objects on destruction, in a TestGroupDataProvider unit test.

(Replacing issue #11880 Possible use of destroyed pool objects with specific issues for the few remaining instances.)

Proposed Solution

Someone with domain knowledge should decide where/whether remaining pool objects should be released (e.g. calling ReleaseAll() in the enclosing class's destructor), or whether some other action should be taken (e.g. extending the lifetime of the enclosing class instances).
@kpschoedel kpschoedel mentioned this issue Dec 2, 2021
Merged
@kpschoedel kpschoedel added the leak Memory leak bug label Dec 7, 2021
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 7, 2021
@kpschoedel
Remove ObjectPool leak from from GroupDataProviderImpl::mKeySetIterators
9545076 
#### Problem

The `ObjectPool` leak reported in project-chip#12503 _ObjectPool leaks in GroupDataProviderImpl_

#### Change overview

Remove the ‘allow leaks’ flag from `GroupDataProviderImpl::mKeySetIterators`.

#### Testing

CI.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 7, 2021
@kpschoedel
Remove ObjectPool leak from from GroupDataProviderImpl::mKeySetIterators
063e335 
#### Problem

The `ObjectPool` leak reported in project-chip#12503 _ObjectPool leaks in
GroupDataProviderImpl_ is no longer reproducable; possibly fixed
by d25a3ef.

#### Change overview

Remove the ‘allow leaks’ flag from `GroupDataProviderImpl::mKeySetIterators`.

#### Testing

CI.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 8, 2021
@kpschoedel
Remove ObjectPool leak flag from GroupDataProviderImpl::mKeySetIterators
240a4f9 
#### Problem

The `ObjectPool` leak reported in project-chip#12503 _ObjectPool leaks in
GroupDataProviderImpl_ is no longer reproducable; possibly fixed
by d25a3ef.

#### Change overview

Remove the ‘allow leaks’ flag from `GroupDataProviderImpl::mKeySetIterators`.

#### Testing

CI.
@kpschoedel kpschoedel mentioned this issue Dec 8, 2021
Merged
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 8, 2021
@kpschoedel
Remove ObjectPool leak flag from GroupDataProviderImpl::mKeySetIterators
3963733 
#### Problem

The `ObjectPool` leak reported in project-chip#12503 _ObjectPool leaks in
GroupDataProviderImpl_ is no longer reproducable; possibly fixed
by d25a3ef.

#### Change overview

Remove the ‘allow leaks’ flag from `GroupDataProviderImpl::mKeySetIterators`.

#### Testing

CI.
andy31415 pushed a commit that referenced this issue Dec 8, 2021
@kpschoedel
Remove ObjectPool leak flag from GroupDataProviderImpl::mKeySetIterat…
20ee197 
…ors (#12734)

#### Problem

The `ObjectPool` leak reported in #12503 _ObjectPool leaks in
GroupDataProviderImpl_ is no longer reproducable; possibly fixed
by d25a3ef.

#### Change overview

Remove the ‘allow leaks’ flag from `GroupDataProviderImpl::mKeySetIterators`.

#### Testing

CI.
@kpschoedel
Copy link
Contributor Author

Closed by #12734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
leak Memory leak bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpschoedel