Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app/util/basic-types.h types need to live lower #10924

Closed
mlepage-google opened this issue Oct 25, 2021 · 0 comments
Closed

app/util/basic-types.h types need to live lower #10924

mlepage-google opened this issue Oct 25, 2021 · 0 comments
Assignees
@mlepage-google

Comments

@mlepage-google
Copy link
Contributor

We have basic types (e.g. FabricIndex) in app/util/basic-types.h which also need to be used by modules lower than app (e.g. messaging, access control). Therefore these types need to be refactored to live at a lower level.
@mlepage-google mlepage-google self-assigned this Oct 25, 2021
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Oct 25, 2021
@mlepage-google
Move basic types from app to core
17acb32 
We have a lot of low level types (e.g. FabricIndex) defined in
app/util/basic-types.h. These need to be used by other modules outside
of app (e.g. messaging, access control) which are lower level than app.

Right now the best low level place for these types is in lib/core. So,
moving them there for now, in a header called DataModelTypes.h. If we
need a more intermediate level (above core, below the other modules) in
the future, we can refactor then.

Issue project-chip#10924
This was referenced Oct 25, 2021
Merged
Merged
andy31415 pushed a commit that referenced this issue Oct 26, 2021
@mlepage-google
Move basic types from app to core (#10925)
fd34f21 
We have a lot of low level types (e.g. FabricIndex) defined in
app/util/basic-types.h. These need to be used by other modules outside
of app (e.g. messaging, access control) which are lower level than app.

Right now the best low level place for these types is in lib/core. So,
moving them there for now, in a header called DataModelTypes.h. If we
need a more intermediate level (above core, below the other modules) in
the future, we can refactor then.

Issue #10924
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this issue Oct 28, 2021
@mlepage-google @JasonLiuZhuoCheng
Move basic types from app to core (project-chip#10925)
73618a2 
We have a lot of low level types (e.g. FabricIndex) defined in
app/util/basic-types.h. These need to be used by other modules outside
of app (e.g. messaging, access control) which are lower level than app.

Right now the best low level place for these types is in lib/core. So,
moving them there for now, in a header called DataModelTypes.h. If we
need a more intermediate level (above core, below the other modules) in
the future, we can refactor then.

Issue project-chip#10924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlepage-google mlepage-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mlepage-google