Skip to content

Commit

Permalink
Remove handling of the unitTestInject* bits in base MTRDevice. (#35180)
Browse files Browse the repository at this point in the history
These injections need to be handled by subclasses, because the subclasses do
very different report processing and have different mechanisms for getting
reports.

Once these implementations are removed, the following become unreachable and can
be removed:

* _handleEventReport
* _handleReportBegin
* _handleAttributeReport
* _handleReportEnd

Once those are removed, the following become unreachable or unused and can be
removed:

* _receivingReport (always false)
* _receivingPrimingReport (always false, because _receivingReport is always false)
* _changeState
* _callDelegateDeviceCachePrimed
* unreportedEvents
* _getAttributesToReportWithReportedValues

Once those are removed, the following become unreachable or unused and can be
removed:

* _setCachedAttributeValue
* _noteDataVersion
* _deviceConfigurationChanged
* estimatedStartTimeFromGeneralDiagnosticsUpTime
* _attributeAffectsDeviceConfiguration
* _pruneStoredDataForPath

Once those are removed, the following become unreachable or unused and can be
removed:

* _pruneEndpointsIn
* _pruneClustersIn
* _pruneAttributesIn
* _attributePathAffectsDescriptionData
* _addInformationalAttributesToCurrentMetricScope
* AttributeHasChangesOmittedQuality

Once those are removed, the following become unreachable or unused and can be
removed:

* _removeAttributes
* _removeClusters

Once those are removed, the following become unreachable or unused and can be
removed:

* _removeCachedAttribute
  • Loading branch information
bzbarsky-apple authored Aug 27, 2024
1 parent aa508e6 commit e20355a
Showing 1 changed file with 3 additions and 739 deletions.
Loading

0 comments on commit e20355a

Please sign in to comment.