Skip to content

Commit

Permalink
TC-PS-3.1: Add cluster revision check
Browse files Browse the repository at this point in the history
This allows the test suite to be dual-purposed against existing
devices in the field as well as being used for cert. Correct cluster
revision for cert testing purposes is tested in the TC-PS-1.1 test.

Test: Down-rev'd one PS cluster on all clusters and removed
      EndpointList - saw note, test passes.
  • Loading branch information
cecille committed Aug 2, 2023
1 parent 3b5b350 commit c9bbcb7
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/python_testing/TC_DeviceBasicComposition.py
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,15 @@ def test_TC_PS_3_1(self):
for endpoint_id, endpoint in self.endpoints.items():
if Clusters.PowerSource not in endpoint:
continue
location = AttributePathLocation(endpoint_id=endpoint_id, cluster_id=cluster_id, attribute_id=attribute_id)
if Clusters.PowerSource.Attributes.ClusterRevision not in endpoint[Clusters.PowerSource]:
self.record_error(self.get_test_name(
), location=location, problem=f'Did not find Cluster revision on {location.as_cluster_string(self.cluster_mapper)}', spec_location='Global attributes')
if endpoint[Clusters.PowerSource][Clusters.PowerSource.Attributes.ClusterRevision] < 2:
self.record_note(self.get_test_name(), location=location,
problem=f'Power source ClusterRevision is < 2, skipping remainder of test for this endpoint')
continue
if Clusters.PowerSource.Attributes.EndpointList not in endpoint[Clusters.PowerSource]:
location = AttributePathLocation(endpoint_id=endpoint_id, cluster_id=cluster_id, attribute_id=attribute_id)
self.record_error(self.get_test_name(), location=location,
problem=f'Did not find {attribute_string} on {location.as_cluster_string(self.cluster_mapper)}', spec_location="EndpointList Attribute")
success = False
Expand Down

0 comments on commit c9bbcb7

Please sign in to comment.