Skip to content

Commit

Permalink
Make group cluster match the spec (#30056)
Browse files Browse the repository at this point in the history
* Set the max length of the group name in command arguments

* ZAP regen

* minor change to kick CI

* NOOP change to kick ci
  • Loading branch information
andy31415 authored Oct 27, 2023
1 parent 851b001 commit bd8aa07
Show file tree
Hide file tree
Showing 51 changed files with 153 additions and 154 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_fan_7N2TobIlOX.matter
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -84,7 +84,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -95,7 +95,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_flowsensor_1zVxHedlaV.matter
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ client cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -76,7 +76,7 @@ client cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

request struct GetGroupMembershipRequest {
Expand All @@ -99,7 +99,7 @@ client cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

/** Command description for AddGroup */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ server cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

request struct ViewGroupRequest {
Expand All @@ -78,7 +78,7 @@ server cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -89,7 +89,7 @@ server cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

response struct GetGroupMembershipResponse = 2 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ client cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -76,7 +76,7 @@ client cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

request struct GetGroupMembershipRequest {
Expand All @@ -99,7 +99,7 @@ client cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

/** Command description for AddGroup */
Expand Down
6 changes: 3 additions & 3 deletions examples/chef/devices/rootnode_lightsensor_lZQycTFcJK.matter
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ client cluster Groups = 4 {

request struct AddGroupRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

response struct AddGroupResponse = 0 {
Expand All @@ -76,7 +76,7 @@ client cluster Groups = 4 {
response struct ViewGroupResponse = 1 {
enum8 status = 0;
group_id groupID = 1;
char_string groupName = 2;
char_string<16> groupName = 2;
}

request struct GetGroupMembershipRequest {
Expand All @@ -99,7 +99,7 @@ client cluster Groups = 4 {

request struct AddGroupIfIdentifyingRequest {
group_id groupID = 0;
char_string groupName = 1;
char_string<16> groupName = 1;
}

/** Command description for AddGroup */
Expand Down
Loading

0 comments on commit bd8aa07

Please sign in to comment.