Fixed a bug in ReadHandler's destructor that failed to deregister one of

two timer callbacks, resulting in it firing after the object's destruction and causing all kinds of memory corruption havoc that took 3 hours to debug.
project-chip · Jan 26, 2022 · a35b0f6 · a35b0f6
1 parent cdd5849
commit a35b0f6
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/app/ReadHandler.cpp b/src/app/ReadHandler.cpp
@@ -84,6 +84,9 @@ ReadHandler::~ReadHandler()
 
     if (IsType(InteractionType::Subscribe))
     {
+        InteractionModelEngine::GetInstance()->GetExchangeManager()->GetSessionManager()->SystemLayer()->CancelTimer(
+            OnUnblockHoldReportCallback, this);
+
         InteractionModelEngine::GetInstance()->GetExchangeManager()->GetSessionManager()->SystemLayer()->CancelTimer(
             OnRefreshSubscribeTimerSyncCallback, this);
     }