-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RFC: Add common 3rd party warnings config target (#7959)
There is an idiom for relaxing warnings for third party in GN: configs -= [ "//buildsys/1st_party_warnings" ] configs += [ "//buildsys/3rd_party_warnings" ] The trouble is that "//buildsys/1st_party_warnings" is an object from the core build system that we have to name which introduces some coupling (e.g., projects may have the same pattern with different target names and this would not work). To minimize this coupling, indirect this through the build_overrides directory where the top level project can provide suitable targets (or not, if the defaults already work). This is provided for discussion in issue #7935
- Loading branch information
Showing
4 changed files
with
51 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters