Skip to content

Commit

Permalink
Remove gdbgui requirement for esp32 (#28007)
Browse files Browse the repository at this point in the history
* Remove gdbgui requirement for esp32

* Fix qemu

* Fix chef as well
  • Loading branch information
andy31415 authored and pull[bot] committed Jan 24, 2024
1 parent 5e6a6b8 commit 7517267
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/chef.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ jobs:
uses: ./.github/actions/checkout-submodules-and-bootstrap
with:
platform: esp32
- name: Fixup GdbGui requirement
run: perl -i -pe 's/^gdbgui==/# gdbgui==/' /opt/espressif/esp-idf/requirements.txt
- name: CI Examples ESP32
shell: bash
run: |
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/examples-esp32.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ jobs:
with:
platform: esp32

- name: Fixup GdbGui requirement
run: perl -i -pe 's/^gdbgui==/# gdbgui==/' /opt/espressif/esp-idf/requirements.txt

- name: Set up environment for size reports
uses: ./.github/actions/setup-size-reports
if: ${{ !env.ACT }}
Expand Down Expand Up @@ -139,6 +142,9 @@ jobs:
with:
platform: esp32

- name: Fixup GdbGui requirement
run: perl -i -pe 's/^gdbgui==/# gdbgui==/' /opt/espressif/esp-idf/requirements.txt

- name: Build example Bridge App
run: scripts/examples/esp_example.sh bridge-app

Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/qemu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ jobs:
with:
platform: esp32

- name: Fixup GdbGui requirement
run: perl -i -pe 's/^gdbgui==/# gdbgui==/' /opt/espressif/esp-idf/requirements.txt

- name: Build ESP32 QEMU test images
run: |
scripts/run_in_build_env.sh " \
Expand Down
7 changes: 6 additions & 1 deletion scripts/setup/requirements.esp32.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,9 @@ kconfiglib==13.7.1
construct==2.10.54
python-socketio<5
itsdangerous<2.1 ; python_version < "3.11"
gdbgui==0.13.2.0 ; python_version < "3.11" and platform_machine != 'aarch64' and sys_platform == 'linux'
#
# gdbgui pulls in gevent which fails to compile due to cython updates.
# Could not find a good way to fix this dependency, so commenting it
# out here.
#
# gdbgui==0.13.2.0 ; python_version < "3.11" and platform_machine != 'aarch64' and sys_platform == 'linux'

0 comments on commit 7517267

Please sign in to comment.