Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
  • Loading branch information
hasty and bzbarsky-apple authored Aug 28, 2024
1 parent ee375eb commit 6c0101c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/app/clusters/thermostat-server/thermostat-server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ void ThermostatAttrAccess::OnFabricRemoved(const FabricTable & fabricTable, Fabr
}
}

void MatterThermostatClusterServerAttributeChangedCallback(const chip::app::ConcreteAttributePath & attributePath)
void MatterThermostatClusterServerAttributeChangedCallback(const ConcreteAttributePath & attributePath)
{
uint32_t flags;
if (FeatureMap::Get(attributePath.mEndpointId, &flags) != Status::Success)
Expand All @@ -477,7 +477,7 @@ void MatterThermostatClusterServerAttributeChangedCallback(const chip::app::Conc
return;
}

auto featureMap = chip::BitMask<Feature, uint32_t>(flags);
auto featureMap = BitMask<Feature, uint32_t>(flags);
if (!featureMap.Has(Feature::kPresets))
{
// This server does not support presets, so nothing to do
Expand All @@ -487,7 +487,7 @@ void MatterThermostatClusterServerAttributeChangedCallback(const chip::app::Conc
bool occupied = true;
if (featureMap.Has(Feature::kOccupancy))
{
chip::BitMask<OccupancyBitmap, uint8_t> occupancy;
BitMask<OccupancyBitmap, uint8_t> occupancy;
if (Occupancy::Get(attributePath.mEndpointId, &occupancy) == Status::Success)
{
occupied = occupancy.Has(OccupancyBitmap::kOccupied);
Expand Down Expand Up @@ -808,7 +808,7 @@ MatterThermostatClusterServerPreAttributeChangedCallback(const app::ConcreteAttr
}
}

void MatterThermostatClusterServerAttributeChangedCallback(const chip::app::ConcreteAttributePath & attributePath)
void MatterThermostatClusterServerAttributeChangedCallback(const ConcreteAttributePath & attributePath)
{
Thermostat::MatterThermostatClusterServerAttributeChangedCallback(attributePath);
}
Expand Down

0 comments on commit 6c0101c

Please sign in to comment.