Skip to content

Commit

Permalink
[Python] Use thread-safe futures for concurrent operations (#33891)
Browse files Browse the repository at this point in the history
* [Python] Use thread-safe futures for concurrent operations

Instead of using quasi-global variables in the ChipStack singleton
use device controller local futures to store results from callbacks.
This has several advantages, namely:
- Avoid unnecessary shared state between device controllers
- Avoid unnecessary shared state between various operations within a
  device controller (those who don't share callbacks could be called
  from different threads now)
- Explicitly set Futures to None to detect spurious/unexpected callbacks
- Better code readability
- concurrent.futures are thread-safe
- Will make asyncio transition easier

This change shouldn't change the external API.

* [Python] Fix EstablishPASESession API compatibility

* [Python] Make ConnectBLE behave as before
  • Loading branch information
agners authored Jun 13, 2024
1 parent 3271a8e commit 645d3a7
Show file tree
Hide file tree
Showing 2 changed files with 184 additions and 160 deletions.
Loading

0 comments on commit 645d3a7

Please sign in to comment.