Skip to content

Commit

Permalink
Fix test_suites.sh to fail if the chip-tool command fails. (#11593)
Browse files Browse the repository at this point in the history
If chip-tool crashed, the script was not treating this as a failure,
because the default exit code of a pipeline is that of the last
command in the pipeline and we are piping through tee.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Dec 21, 2023
1 parent f9de738 commit 5898240
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions scripts/tests/test_suites.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@
# limitations under the License.
#

# Fail if one of our sub-commands fails.
set -e

# Fail if anything in a pipeline fails, not just the last command (which for
# us tends to be 'tee').
set -o pipefail

declare -i iterations=2
declare -i delay=0
declare -i node_id=0x12344321
Expand Down

0 comments on commit 5898240

Please sign in to comment.