address review comments

project-chip · Oct 16, 2024 · 544a6dd · 544a6dd
1 parent 0ba47bb
commit 544a6dd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/platform/ESP32/BUILD.gn b/src/platform/ESP32/BUILD.gn
@@ -206,8 +206,7 @@ static_library("ESP32") {
   }
 
   if (chip_use_factory_data_provider && chip_use_secure_cert_dac_provider) {
-    # These files has no dependency on chip_use_secure_cert_dac_provider but if we are reading the commissionable data from
-    # from secure cert then we should expect that the attestation data is present there as well.
+    # These files have no dependency on chip_use_secure_cert_dac_provider, but if we are reading the commissionable data from the secure cert, we should expect the attestation data to be present there as well.
     sources += [
       "ESP32SecureCertDataProvider.cpp",
       "ESP32SecureCertDataProvider.h",

diff --git a/src/platform/ESP32/ESP32SecureCertDataProvider.cpp b/src/platform/ESP32/ESP32SecureCertDataProvider.cpp
@@ -133,8 +133,12 @@ CHIP_ERROR ESP32SecureCertDataProvider::GetSpake2pVerifier(MutableByteSpan & ver
 
 CHIP_ERROR ESP32SecureCertDataProvider::GetRotatingDeviceIdUniqueId(MutableByteSpan & uniqueIdSpan)
 {
+#if CHIP_ENABLE_ROTATING_DEVICE_ID
     ScopedTLVInfo tlvInfo(MatterTLVSubType::kRotatingDeviceIdUniqueId);
     return tlvInfo.GetValue(uniqueIdSpan);
+#else
+    return CHIP_ERROR_NOT_IMPLEMENTED;
+#endif // CHIP_ENABLE_ROTATING_DEVICE_ID
 }
 
 } // namespace DeviceLayer