Skip to content

Commit

Permalink
Nits
Browse files Browse the repository at this point in the history
  • Loading branch information
aBozowski committed Feb 6, 2024
1 parent 4a97230 commit 4096715
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 8 deletions.
9 changes: 3 additions & 6 deletions src/tools/interop/idt/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ options:
- If the build script fails for you, try `idt_linux_install_compilers_for_arm_tcpdump`.
- You may disable colors and splash by setting `ENABLE_COLOR` in `config.py`
to `False`.
- `idt_child_clean` will kill any stray `tcpdump` and `adb` commands.
- `idt_child_kill` will kill any stray `tcpdump` and `adb` commands.
- `idt_child_check` will look for leftover processes.
- Not expected to be needed outside of development scenarios.

Expand All @@ -313,7 +313,7 @@ options:

#### `advertise`

- `advertise` re-uses the library used in discovery to produce dns-sd advertisements mimicking matter devices.
- `advertise` re-uses the library used in discovery to produce DNS-SD advertisements mimicking matter devices.

#### `capture`

Expand Down Expand Up @@ -342,10 +342,7 @@ options:

#### `setup`

- Contains setup implementations. The only requirement for a setup implementation is a class with a single method
(`setup`).
- The package itself (not implementations) is very minimal. It exists just to glue purpose built scripts
(the setup implementation) to the main commandline args.
- Contains setup implementations.

### `utils`

Expand Down
16 changes: 16 additions & 0 deletions src/tools/interop/idt/features/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#
# Copyright (c) 2023 Project CHIP Authors
# All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
4 changes: 2 additions & 2 deletions src/tools/interop/idt/idt.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def __init__(self) -> None:
if create_artifact_dir:
safe_mkdir(self.artifact_dir)
border_print(f"Using artifact dir {self.artifact_dir}")

# TODO: Make the choices readable
self.advertise_device_type_choices = [int(i, 16) for i in MATTER_APPLICATION_DEVICE_TYPES.keys()]

self.capture_platforms_choices = controller.list_available_platforms()
Expand All @@ -84,7 +84,7 @@ def __init__(self) -> None:
self.capture_ecosystems_default = "ALL"
self.capture_ecosystems_choices.append(self.capture_ecosystems_default)
self.capture_pcap_interfaces_choices = current_platform.get_interfaces_available_for_pcap()
# TODO: No None below
# TODO: No None for capture_pcap_interfaces_default
self.capture_pcap_interfaces_default = "any" if "any" in self.capture_pcap_interfaces_choices else None
self.capture_pcap_interface_required = self.capture_pcap_interfaces_default is None
self.capture_pcap_wlan_channel_default, self.capture_pcap_wlan_width_default = current_platform. \
Expand Down

0 comments on commit 4096715

Please sign in to comment.