Skip to content

Commit

Permalink
[Python] Make ConnectBLE behave as before
Browse files Browse the repository at this point in the history
  • Loading branch information
agners committed Jun 13, 2024
1 parent aa4a78a commit 3c24956
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/controller/python/chip/ChipDeviceCtrl.py
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,11 @@ def ConnectBLE(self, discriminator, setupPinCode, nodeid) -> PyChipError:
self.devCtrl, discriminator, setupPinCode, nodeid)
).raise_on_error()

return self._commissioning_complete_future.result()
# TODO: Change return None. Only returning on success is not useful.
# but that is what the previous implementation did.
res = self._commissioning_complete_future.result()
res.raise_on_error()
return res
finally:
self._commissioning_complete_future = None

Expand Down

0 comments on commit 3c24956

Please sign in to comment.