Skip to content

Commit

Permalink
Align header include paths between Release and Debug configuration (#…
Browse files Browse the repository at this point in the history
…7632)

* Align header include paths between Release and Debug configuration

* Add a CI step for release configurations

* Try and make restyled happy

* Fix format
  • Loading branch information
sagar-apple authored Jun 16, 2021
1 parent b728b74 commit 33ee77a
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/darwin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,14 @@ jobs:
path: |
.environment/gn_out/.ninja_log
.environment/pigweed-venv/*.log
- name: Run iOS Build
- name: Run iOS Build Debug
timeout-minutes: 15
working-directory: src/darwin/Framework
run: xcodebuild -target "CHIP" -sdk iphoneos
- name: Run iOS Build Release
timeout-minutes: 15
working-directory: src/darwin/Framework
run: xcodebuild -target "CHIP" -sdk iphoneos -configuration Release
- name: Clean Build
run: xcodebuild clean
working-directory: src/darwin/Framework
Expand Down
2 changes: 1 addition & 1 deletion src/app/util/binding-table.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
* @file Basic implementation of a binding table.
*/

#include "gen/gen_config.h"
#include <app/util/binding-table.h>
#include <gen/gen_config.h>

static EmberBindingTableEntry bindingTable[EMBER_BINDING_TABLE_SIZE];

Expand Down
5 changes: 4 additions & 1 deletion src/darwin/Framework/CHIP.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -724,8 +724,11 @@
"$(CHIP_ROOT)/src/app",
"$(CHIP_ROOT)/config/ios",
"$(CHIP_ROOT)/third_party/nlassert/repo/include",
.,
"$(CHIP_ROOT)/src/darwin/Framework/CHIP/",
"$(CHIP_ROOT)/src/app/util",
"$(CHIP_ROOT)/third_party/nlio/repo/include",
"$(TEMP_DIR)/out/gen/include",
"$(CHIP_ROOT)/src/controller/data_model",
);
INFOPLIST_FILE = CHIP/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
Expand Down

0 comments on commit 33ee77a

Please sign in to comment.