Skip to content

Commit

Permalink
Remove TODO item which is no more valid (#21591)
Browse files Browse the repository at this point in the history
  • Loading branch information
yufengwangca authored and pull[bot] committed Jan 9, 2024
1 parent d969d96 commit 2301208
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -739,8 +739,6 @@ bool emberAfOperationalCredentialsClusterAddNOCCallback(app::CommandHandler * co
(void) groupDataProvider->RemoveFabric(newFabricIndex);
}

// TODO(#19898): All ACL work done within AddNOC does not trigger ACL cluster updates

(void) Access::GetAccessControl().DeleteAllEntriesForFabric(newFabricIndex);

MatterReportingAttributeChangeCallback(commandPath.mEndpointId, OperationalCredentials::Id,
Expand Down
2 changes: 0 additions & 2 deletions src/app/server/Server.h
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,7 @@ class Server
// Remove access control entries in reverse order (it could be any order, but reverse order
// will cause less churn in persistent storage).

// TODO(#19898): The fabric removal not trigger ACL cluster updates
// TODO(#19899): The fabric removal not remove ACL extensions

CHIP_ERROR aclErr = Access::GetAccessControl().DeleteAllEntriesForFabric(fabricIndex);
if (aclErr != CHIP_NO_ERROR)
{
Expand Down

0 comments on commit 2301208

Please sign in to comment.