Enable -Wconversion in Tizen platform code. (#25408)

project-chip · May 3, 2024 · 2150434 · 2150434
1 parent d220bf9
commit 2150434
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/src/platform/Tizen/BUILD.gn b/src/platform/Tizen/BUILD.gn
@@ -106,4 +106,6 @@ static_library("Tizen") {
       "WiFiManager.h",
     ]
   }
+
+  cflags = [ "-Wconversion" ]
 }
diff --git a/src/platform/Tizen/NetworkCommissioningEthernetDriver.cpp b/src/platform/Tizen/NetworkCommissioningEthernetDriver.cpp
@@ -61,7 +61,8 @@ bool TizenEthernetDriver::EthernetNetworkIterator::Next(Network & item)
     VerifyOrReturnValue(mInterfacesIdx < mInterfaces.size(), false);
 
     const auto & iface = mInterfaces[mInterfacesIdx++];
-    item.networkIDLen  = std::min(iface.size(), kMaxNetworkIDLen);
+    static_assert(kMaxNetworkIDLen <= UINT8_MAX, "Our length won't fit in networkIDLen");
+    item.networkIDLen = static_cast<uint8_t>(std::min(iface.size(), kMaxNetworkIDLen));
     memcpy(item.networkID, iface.c_str(), item.networkIDLen);
     item.connected = true;
 

diff --git a/src/platform/Tizen/NetworkCommissioningWiFiDriver.cpp b/src/platform/Tizen/NetworkCommissioningWiFiDriver.cpp
@@ -59,8 +59,11 @@ CHIP_ERROR TizenWiFiDriver::Init(BaseDriver::NetworkStatusChangeCallback * netwo
     {
         return CHIP_NO_ERROR;
     }
-    mSavedNetwork.credentialsLen = credentialsLen;
-    mSavedNetwork.ssidLen        = ssidLen;
+    static_assert(sizeof(mSavedNetwork.credentials) <= UINT8_MAX, "credentialsLen might not fit");
+    mSavedNetwork.credentialsLen = static_cast<uint8_t>(credentialsLen);
+
+    static_assert(sizeof(mSavedNetwork.ssid) <= UINT8_MAX, "ssidLen might not fit");
+    mSavedNetwork.ssidLen = static_cast<uint8_t>(ssidLen);
 
     mStagingNetwork = mSavedNetwork;
     return err;