Fix merge error causing test failures. (#14773)

Merging #14487
violated the API contract that was established in
#14688, so we
started failing tests.  The two PRs had never been run through CI
together.

src/credentials/FabricTable.cpp

@@ -601,10 +601,17 @@ CHIP_ERROR FabricTable::Delete(FabricIndex index)
     bool fabricIsInitialized = fabric != nullptr && fabric->IsInitialized();
     CompressedFabricId compressedFabricId =
         fabricIsInitialized ? fabric->GetPeerId().GetCompressedFabricId() : kUndefinedCompressedFabricId;
-    ReturnErrorOnFailure(FabricInfo::DeleteFromStorage(mStorage, index)); // Delete from storage regardless
+    CHIP_ERROR err = FabricInfo::DeleteFromStorage(mStorage, index); // Delete from storage regardless
+    if (!fabricIsInitialized)
+    {
+        // Make sure to return the error our API promises, not whatever storage
+        // chose to return.
+        return CHIP_ERROR_NOT_FOUND;
+    }
+    ReturnErrorOnFailure(err);
 
     ReleaseFabricIndex(index);
-    if (mDelegate != nullptr && fabricIsInitialized)
+    if (mDelegate != nullptr)
     {
         if (mFabricCount == 0)
         {
@@ -622,10 +629,6 @@ CHIP_ERROR FabricTable::Delete(FabricIndex index)
             delegate = delegate->mNext;
         }
     }
-    if (!fabricIsInitialized)
-    {
-        return CHIP_ERROR_NOT_FOUND;
-    }
     return CHIP_NO_ERROR;
 }