Clang tidy readability-redundant-* (#17121)

* Ran clang-tidy using readability-redundant-*

* Restyle

* Add back session holder init: it looks like -Wextra is more strict on what calls should be made on base classes

examples/chip-tool/commands/common/CHIPCommand.cpp

@@ -118,7 +118,7 @@ CHIP_ERROR CHIPCommand::MaybeSetUpStack()
     chip::FabricId fabricId = strtoull(name.c_str(), nullptr, 0);
     if (fabricId >= kIdentityOtherFabricId)
     {
-        ReturnLogErrorOnFailure(InitializeCommissioner(name.c_str(), fabricId, trustStore));
+        ReturnLogErrorOnFailure(InitializeCommissioner(name, fabricId, trustStore));
     }
 
     // Initialize Group Data, including IPK
@@ -168,7 +168,7 @@ CHIP_ERROR CHIPCommand::MaybeTearDownStack()
     chip::FabricId fabricId = strtoull(name.c_str(), nullptr, 0);
     if (fabricId >= kIdentityOtherFabricId)
     {
-        ReturnLogErrorOnFailure(ShutdownCommissioner(name.c_str()));
+        ReturnLogErrorOnFailure(ShutdownCommissioner(name));
     }
 
     StopTracing();
@@ -286,7 +286,7 @@ chip::FabricId CHIPCommand::CurrentCommissionerId()
 chip::Controller::DeviceCommissioner & CHIPCommand::CurrentCommissioner()
 {
     auto item = mCommissioners.find(GetIdentity());
-    return *item->second.get();
+    return *item->second;
 }
 
 CHIP_ERROR CHIPCommand::ShutdownCommissioner(std::string key)

examples/chip-tool/commands/common/Commands.cpp

@@ -310,7 +310,7 @@ void Commands::ShowCommand(std::string executable, std::string clusterName, Comm
 {
     fprintf(stderr, "Usage:\n");
 
-    std::string arguments = "";
+    std::string arguments;
     arguments += command->GetName();
 
     size_t argumentsCount = command->GetArgumentsCount();

src/access/AccessControl.h

@@ -213,7 +213,6 @@ class AccessControl
          */
         CHIP_ERROR RemoveTarget(size_t index) { return mDelegate->RemoveTarget(index); }
 
-    public:
         const Delegate & GetDelegate() const { return *mDelegate; }
 
         Delegate & GetDelegate() { return *mDelegate; }
@@ -267,7 +266,6 @@ class AccessControl
 
         CHIP_ERROR Next(Entry & entry) { return mDelegate->Next(entry); }
 
-    public:
         const Delegate & GetDelegate() const { return *mDelegate; }
 
         Delegate & GetDelegate() { return *mDelegate; }

src/access/examples/ExampleAccessControlDelegate.cpp

@@ -130,7 +130,6 @@ class SubjectStorage
         return CHIP_ERROR_INVALID_ARGUMENT;
     }
 
-public:
     CHIP_ERROR Serialize(chip::TLV::TLVWriter & writer) const { return writer.Put(chip::TLV::AnonymousTag(), mNode); }
 
     CHIP_ERROR Deserialize(chip::TLV::TLVReader & reader)
@@ -142,10 +141,8 @@ class SubjectStorage
 private:
     static bool IsValid(NodeId node) { return node != kUndefinedNodeId; }
 
-private:
     static_assert(sizeof(NodeId) == 8, "Expecting 8 byte node ID");
 
-private:
     NodeId mNode;
 };
 
@@ -194,7 +191,6 @@ class TargetStorage
         return CHIP_ERROR_INVALID_ARGUMENT;
     }
 
-public:
     CHIP_ERROR Serialize(chip::TLV::TLVWriter & writer) const
     {
         ReturnErrorOnFailure(writer.Put(chip::TLV::AnonymousTag(), mCluster));
@@ -241,7 +237,6 @@ class TargetStorage
             !((target.flags & Target::kDeviceType) && !IsValidDeviceType(target.deviceType));
     }
 
-private:
     void Decode(Target & target) const
     {
         auto & flags      = target.flags;
@@ -297,7 +292,6 @@ class TargetStorage
         }
     }
 
-private:
     static_assert(sizeof(ClusterId) == 4, "Expecting 4 byte cluster ID");
     static_assert(sizeof(EndpointId) == 2, "Expecting 2 byte endpoint ID");
     static_assert(sizeof(DeviceTypeId) == 4, "Expecting 4 byte device type ID");
@@ -346,7 +340,6 @@ class TargetStorage
     // (mDeviceType >> kEndpointShift) --> extract endpoint from mDeviceType
     static constexpr int kEndpointShift = 16;
 
-private:
     ClusterId mCluster;
     DeviceTypeId mDeviceType;
 };
@@ -390,7 +383,6 @@ class EntryStorage
         return nullptr;
     }
 
-public:
     // Pool support
     static EntryStorage pool[kEntryStoragePoolSize];
 
@@ -419,7 +411,6 @@ class EntryStorage
         return pool <= this && this < end;
     }
 
-public:
     EntryStorage() = default;
 
     void Init()
@@ -457,7 +448,6 @@ class EntryStorage
         }
     }
 
-public:
     enum class ConvertDirection
     {
         kAbsoluteToRelative,
@@ -512,7 +502,6 @@ class EntryStorage
         index = found ? toIndex : ArraySize(acl);
     }
 
-public:
     static constexpr uint8_t kTagInUse       = 1;
     static constexpr uint8_t kTagFabricIndex = 2;
     static constexpr uint8_t kTagAuthMode    = 3;
@@ -598,7 +587,6 @@ class EntryStorage
         return reader.ExitContainer(container);
     }
 
-public:
     static constexpr size_t kMaxSubjects = CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_MAX_SUBJECTS_PER_ENTRY;
     static constexpr size_t kMaxTargets  = CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_MAX_TARGETS_PER_ENTRY;
 
@@ -648,7 +636,6 @@ class EntryDelegate : public Entry::Delegate
         return pool <= &delegate && &delegate < end;
     }
 
-public:
     void Release() override
     {
         mStorage->Release();
@@ -840,7 +827,6 @@ class EntryDelegate : public Entry::Delegate
         return CHIP_ERROR_SENTINEL;
     }
 
-public:
     void Init(Entry & entry, EntryStorage & storage)
     {
         entry.SetDelegate(*this);
@@ -922,7 +908,6 @@ class EntryIteratorDelegate : public EntryIterator::Delegate
         return pool <= &delegate && &delegate < end;
     }
 
-public:
     void Release() override { mInUse = false; }
 
     CHIP_ERROR Next(Entry & entry) override
@@ -963,7 +948,6 @@ class EntryIteratorDelegate : public EntryIterator::Delegate
         return CHIP_ERROR_SENTINEL;
     }
 
-public:
     void Init(EntryIterator & iterator, const FabricIndex * fabricIndex)
     {
         iterator.SetDelegate(*this);
@@ -1245,7 +1229,6 @@ class AccessControlDelegate : public AccessControl::Delegate
         return CHIP_ERROR_NOT_IMPLEMENTED;
     }
 
-public:
     void SetStorageDelegate(chip::PersistentStorageDelegate * storageDelegate) { mStorageDelegate = storageDelegate; }
 
 private:

src/app/AttributeCache.h

@@ -338,7 +338,6 @@ class AttributeCache : protected ReadClient::Callback
      */
     CHIP_ERROR UpdateCache(const ConcreteDataAttributePath & aPath, TLV::TLVReader * apData, const StatusIB & aStatus);
 
-private:
     //
     // ReadClient::Callback
     //
@@ -360,7 +359,6 @@ class AttributeCache : protected ReadClient::Callback
         return mCallback.OnDeallocatePaths(std::move(aReadPrepareParams));
     }
 
-private:
     Callback & mCallback;
     NodeState mCache;
     std::set<ConcreteAttributePath> mChangedAttributeSet;

src/app/BufferedReadCallback.h

@@ -63,7 +63,6 @@ class BufferedReadCallback : public ReadClient::Callback
      */
     CHIP_ERROR BufferData(const ConcreteDataAttributePath & aPath, TLV::TLVReader * apReader);
 
-private:
     //
     // ReadClient::Callback
     //
@@ -84,7 +83,6 @@ class BufferedReadCallback : public ReadClient::Callback
         return mCallback.OnDeallocatePaths(std::move(aReadPrepareParams));
     }
 
-private:
     /*
      * Given a reader positioned at a list element, allocate a packet buffer, copy the list item where
      * the reader is positioned into that buffer and add it to our buffered list for tracking.

src/app/ReadClient.cpp

@@ -69,7 +69,6 @@ static void DefaultResubscribePolicy(uint32_t aNumCumulativeRetries, uint32_t &
                     "Computing Resubscribe policy: attempts %" PRIu32 ", max wait time %" PRIu32 " ms, selected wait time %" PRIu32
                     " ms",
                     aNumCumulativeRetries, maxWaitTimeInMsec, waitTimeInMsec);
-    return;
 }
 
 ReadClient::ReadClient(InteractionModelEngine * apImEngine, Messaging::ExchangeManager * apExchangeMgr, Callback & apCallback,

src/app/WriteHandler.h

@@ -141,12 +141,11 @@ class WriteHandler : public Messaging::ExchangeDelegate
      */
     void Close();
 
-private: // ExchangeDelegate
+    // ExchangeDelegate
     CHIP_ERROR OnMessageReceived(Messaging::ExchangeContext * apExchangeContext, const PayloadHeader & aPayloadHeader,
                                  System::PacketBufferHandle && aPayload) override;
     void OnResponseTimeout(Messaging::ExchangeContext * apExchangeContext) override;
 
-private:
     Messaging::ExchangeContext * mpExchangeCtx = nullptr;
     WriteResponseMessage::Builder mWriteResponseBuilder;
     State mState           = State::Uninitialized;

src/app/util/af.h

@@ -587,11 +587,6 @@ uint8_t emberAfGetAddressIndex(void);
  */
 EmberNetworkStatus emberAfNetworkState(void);
 
-/**
- * @brief Get this node's radio channel for the current network.
- */
-uint8_t emberAfGetRadioChannel(void);
-
 /**
  * @brief Returns the current network parameters.
  */

src/app/util/ember-compatibility-functions.cpp

@@ -323,7 +323,6 @@ void IncreaseClusterDataVersion(const ConcreteClusterPath & aConcreteClusterPath
         ChipLogDetail(DataManagement, "Endpoint %" PRIx16 ", Cluster " ChipLogFormatMEI " update version to %" PRIx32,
                       aConcreteClusterPath.mEndpointId, ChipLogValueMEI(aConcreteClusterPath.mClusterId), *(version));
     }
-    return;
 }
 
 CHIP_ERROR SendSuccessStatus(AttributeReportIB::Builder & aAttributeReport, AttributeDataIB::Builder & aAttributeDataIBBuilder)

src/controller/python/OpCredsBinding.cpp

@@ -105,7 +105,7 @@ extern chip::Controller::ScriptDevicePairingDelegate sPairingDelegate;
 class TestCommissioner : public chip::Controller::AutoCommissioner
 {
 public:
-    TestCommissioner() : AutoCommissioner() { Reset(); }
+    TestCommissioner() { Reset(); }
     ~TestCommissioner() {}
     CHIP_ERROR SetCommissioningParameters(const chip::Controller::CommissioningParameters & params) override
     {

src/controller/tests/data_model/TestRead.cpp

@@ -212,7 +212,6 @@ class TestReadInteraction : public app::ReadHandler::ApplicationCallback
     // of reads in parallel and wait for them all to succeed.
     static void SubscribeThenReadHelper(nlTestSuite * apSuite, TestContext & aCtx, size_t aSubscribeCount, size_t aReadCount);
 
-private:
     bool mEmitSubscriptionError      = false;
     int32_t mNumActiveSubscriptions  = 0;
     bool mAlterSubscriptionIntervals = false;

src/credentials/FabricTable.cpp

@@ -799,7 +799,6 @@ void FabricTable::UpdateNextAvailableFabricIndex()
     }
 
     mNextAvailableFabricIndex.ClearValue();
-    return;
 }
 
 CHIP_ERROR FabricTable::StoreFabricIndexInfo() const

src/credentials/GroupDataProviderImpl.cpp

@@ -384,7 +384,7 @@ struct GroupData : public GroupDataProvider::GroupInfo, PersistentData<kPersiste
     bool first                      = true;
 
     GroupData() : GroupInfo(nullptr){};
-    GroupData(chip::FabricIndex fabric) : GroupInfo(), fabric_index(fabric) {}
+    GroupData(chip::FabricIndex fabric) : fabric_index(fabric) {}
     GroupData(chip::FabricIndex fabric, chip::GroupId group) : GroupInfo(group, nullptr), fabric_index(fabric) {}
 
     CHIP_ERROR UpdateKey(DefaultStorageKeyAllocator & key) override
@@ -505,7 +505,7 @@ struct KeyMapData : public GroupDataProvider::GroupKey, LinkedData
     chip::GroupId group_id         = kUndefinedGroupId;
     chip::KeysetId keyset_id       = 0;
 
-    KeyMapData() : GroupKey(){};
+    KeyMapData(){};
     KeyMapData(chip::FabricIndex fabric, uint16_t link_id = 0, chip::GroupId group = kUndefinedGroupId, chip::KeysetId keyset = 0) :
         GroupKey(group, keyset), LinkedData(link_id), fabric_index(fabric)
     {}

src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp

@@ -195,8 +195,6 @@ void GenericPlatformManagerImpl_POSIX<ImplClass>::_RunEventLoop()
     // StopEventLoopTask().
     //
     pthread_cond_signal(&mEventQueueStoppedCond);
-
-    return;
 }
 
 template <class ImplClass>

src/inet/IPAddress.h

@@ -125,7 +125,6 @@ class DLL_EXPORT IPAddress
     static constexpr uint16_t kMaxStringLength = INET6_ADDRSTRLEN;
 #endif // CHIP_SYSTEM_CONFIG_USE_SOCKETS || CHIP_SYSTEM_CONFIG_USE_NETWORK_FRAMEWORK
 
-public:
     IPAddress()                        = default;
     IPAddress(const IPAddress & other) = default;
 

src/inet/InetInterface.h

@@ -91,7 +91,6 @@ class InterfaceId
     static constexpr size_t kMaxIfNameLength = Z_DEVICE_MAX_NAME_LEN;
 #endif
 
-public:
     ~InterfaceId() = default;
 
     constexpr InterfaceId() : mPlatformInterface(kPlatformNull) {}

src/lib/dnssd/minimal_mdns/tests/TestMinimalMdnsAllocator.cpp

@@ -36,7 +36,7 @@ constexpr size_t kMaxRecords = 10;
 class TestAllocator : public QueryResponderAllocator<kMaxRecords>
 {
 public:
-    TestAllocator() : QueryResponderAllocator<kMaxRecords>()
+    TestAllocator()
     {
 #if CHIP_CONFIG_MEMORY_DEBUG_DMALLOC
         // void dmalloc_track(const dmalloc_track_t track_func)

src/lib/shell/commands/Config.cpp

@@ -211,7 +211,6 @@ void RegisterConfigCommands()
 
     // Register the root `config` command with the top-level shell.
     Engine::Root().RegisterCommands(&sConfigComand, 1);
-    return;
 }
 
 } // namespace Shell

src/lib/shell/commands/OnboardingCodes.cpp

@@ -170,7 +170,6 @@ void RegisterOnboardingCodesCommands()
 
     // Register the root `device` command with the top-level shell.
     Engine::Root().RegisterCommands(&sDeviceComand, 1);
-    return;
 }
 
 } // namespace Shell

src/messaging/ReliableMessageContext.h

@@ -229,7 +229,6 @@ class ReliableMessageContext
     // will send that ack at some point.
     void SetPendingPeerAckMessageCounter(uint32_t aPeerAckMessageCounter);
 
-private:
     friend class ReliableMessageMgr;
     friend class ExchangeContext;
     friend class ExchangeMessageDispatch;

src/messaging/ReliableMessageMgr.cpp

@@ -41,7 +41,7 @@ namespace chip {
 namespace Messaging {
 
 ReliableMessageMgr::RetransTableEntry::RetransTableEntry(ReliableMessageContext * rc) :
-    ec(*rc->GetExchangeContext()), retainedBuf(EncryptedPacketBufferHandle()), nextRetransTime(0), sendCount(0)
+    ec(*rc->GetExchangeContext()), nextRetransTime(0), sendCount(0)
 {
     ec->SetMessageNotAcked(true);
 }
@@ -89,10 +89,7 @@ void ReliableMessageMgr::TicklessDebugDumpRetransTable(const char * log)
     });
 }
 #else
-void ReliableMessageMgr::TicklessDebugDumpRetransTable(const char * log)
-{
-    return;
-}
+void ReliableMessageMgr::TicklessDebugDumpRetransTable(const char * log) {}
 #endif // RMP_TICKLESS_DEBUG
 
 void ReliableMessageMgr::ExecuteActions()

src/messaging/ReliableMessageMgr.h

@@ -69,7 +69,6 @@ class ReliableMessageMgr
                                                        including both successfully and failure send. */
     };
 
-public:
     ReliableMessageMgr(BitMapObjectPool<ExchangeContext, CHIP_CONFIG_MAX_EXCHANGE_CONTEXTS> & contextPool);
     ~ReliableMessageMgr();
 

src/protocols/user_directed_commissioning/UserDirectedCommissioningServer.cpp

@@ -103,8 +103,6 @@ void UserDirectedCommissioningServer::SetUDCClientProcessingState(char * instanc
     client->SetUDCClientProcessingState(state);
 
     mUdcClients.MarkUDCClientActive(client);
-
-    return;
 }
 
 void UserDirectedCommissioningServer::OnCommissionableNodeFound(const Dnssd::DiscoveredNodeData & nodeData)