Skip to content

Commit

Permalink
[matter_yamltests] Add groupId keyword support to the parser (#24583)
Browse files Browse the repository at this point in the history
* [matter_yamltests] Add groupId keyword support to the parser

* Update tests generated content
  • Loading branch information
vivien-apple authored and pull[bot] committed Feb 22, 2024
1 parent 7c6d7c4 commit 1352b3f
Show file tree
Hide file tree
Showing 4 changed files with 70 additions and 4 deletions.
6 changes: 6 additions & 0 deletions scripts/py_matter_yamltests/matter_yamltests/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
'endpoint',
'identity',
'fabricFiltered',
'groupId',
'verification',
'nodeId',
'attribute',
Expand Down Expand Up @@ -198,6 +199,7 @@ def __init__(self, test: dict, config: dict, definitions: SpecDefinitions, pics_
self.label = _value_or_none(test, 'label')
self.optional = _value_or_none(test, 'optional')
self.node_id = _value_or_config(test, 'nodeId', config)
self.group_id = _value_or_config(test, 'groupId', config)
self.cluster = _value_or_config(test, 'cluster', config)
self.command = _value_or_config(test, 'command', config)
self.attribute = _value_or_none(test, 'attribute')
Expand Down Expand Up @@ -426,6 +428,10 @@ def optional(self):
def node_id(self):
return self._test.node_id

@property
def group_id(self):
return self._test.group_id

@property
def cluster(self):
return self._test.cluster
Expand Down
8 changes: 4 additions & 4 deletions src/app/tests/suites/TestGroupKeyManagementCluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,13 @@ tests:
{
FabricIndex: 1,
GroupId: 0x0103,
endpoints: [1],
Endpoints: [1],
GroupName: "Group #3",
},
{
FabricIndex: 1,
GroupId: 0x0104,
endpoints: [1],
Endpoints: [1],
GroupName: "Group #4",
},
]
Expand Down Expand Up @@ -320,13 +320,13 @@ tests:
{
FabricIndex: 1,
GroupId: 0x0103,
endpoints: [1],
Endpoints: [1],
GroupName: "Group #3",
},
{
FabricIndex: 1,
GroupId: 0x0104,
endpoints: [1],
Endpoints: [1],
GroupName: "Group #4",
},
]
Expand Down
32 changes: 32 additions & 0 deletions zzz_generated/chip-tool/zap-generated/test/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions zzz_generated/darwin-framework-tool/zap-generated/test/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1352b3f

Please sign in to comment.