Skip to content

Commit

Permalink
Schedules and credentials over-the-air features (#13215)
Browse files Browse the repository at this point in the history
* Added support for all server-side attributes except those marked as 'nice-to-have'.
1. ZAP generator extended to generate pre attribute change callback for Door Lock cluster.
2. Door Lock cluster defines list of attribute change callbacks to be implemented by user and proxies pre attribute change request to the user app.

* Added pre-change trap for all unhandled cluster attributes

* Update autogenerated files

* Fixed restyled-io notes

* Fixed CR note (invalid usage of language attribute string)

* Fixed CR notes

* Fixed return values for pre-attribute change callbacks to make Darwin tests pass.

* 1. Fixed bug in DoorLockServer methods: wrong type was used for processing attribute setters' retcode.
2. Implemented empty DoorLockServer methods to set appropriate attributes in the same manner.

* Fixed build issue on Infineon: substituted printf type modificators on portable ones from inttypes.h (to prevent printf size mismatch on different platforms)

* Enabled SCH and COTA features (attributes and commands)

* Update autogenerated files

* Fixed arguments in DoorState and LockState accessors

* Used chip::to_underlying instead of static_cast for Door Lock enum parameters

* Updated autogenerated files

* Fix CR note: added size sanity checks for all cluster attributes

* Update autogenerated files

* Update autogeneretade files

* Avoid usage of null-terminated strings

1. Fixed DoorLock cluster to use chip::CharSpan and chip::ByteSpan types instead of C-strings.

* Update autogenerated files

* Update autogenerated files

* Update autogenerated files

* Update autogenerated files

* Fix zaptool incorrect result

* Update autogenerated files

* Fix zap-tool incorrect file generation
  • Loading branch information
truebiker authored and pull[bot] committed Jan 27, 2022
1 parent 512b322 commit 1174727
Show file tree
Hide file tree
Showing 7 changed files with 751 additions and 321 deletions.
135 changes: 135 additions & 0 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -10420,6 +10420,51 @@
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "DoorOpenEvents",
"code": 4,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "DoorClosedEvents",
"code": 5,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "OpenPeriod",
"code": 6,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfTotalUsersSupported",
"code": 17,
Expand Down Expand Up @@ -10450,6 +10495,51 @@
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfWeekDaySchedulesSupportedPerUser",
"code": 20,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfYearDaySchedulesSupportedPerUser",
"code": 21,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfHolidaySchedulesSupported",
"code": 22,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "MaxPINCodeLength",
"code": 23,
Expand Down Expand Up @@ -10570,6 +10660,21 @@
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "DefaultConfigurationRegister",
"code": 39,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "EnableOneTouchLocking",
"code": 41,
Expand All @@ -10585,6 +10690,21 @@
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "EnableInsideStatusLED",
"code": 42,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "EnablePrivacyModeButton",
"code": 43,
Expand Down Expand Up @@ -10630,6 +10750,21 @@
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "RequirePINforRemoteOperation",
"code": 51,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "ClusterRevision",
"code": 65533,
Expand Down
137 changes: 136 additions & 1 deletion examples/tv-casting-app/tv-casting-common/tv-casting-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -9119,6 +9119,51 @@
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "DoorOpenEvents",
"code": 4,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "DoorClosedEvents",
"code": 5,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "OpenPeriod",
"code": 6,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfTotalUsersSupported",
"code": 17,
Expand Down Expand Up @@ -9149,6 +9194,51 @@
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfWeekDaySchedulesSupportedPerUser",
"code": 20,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfYearDaySchedulesSupportedPerUser",
"code": 21,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "NumberOfHolidaySchedulesSupported",
"code": 22,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "MaxPINCodeLength",
"code": 23,
Expand Down Expand Up @@ -9269,6 +9359,21 @@
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "DefaultConfigurationRegister",
"code": 39,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "EnableOneTouchLocking",
"code": 41,
Expand All @@ -9284,6 +9389,21 @@
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "EnableInsideStatusLED",
"code": 42,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "EnablePrivacyModeButton",
"code": 43,
Expand Down Expand Up @@ -9329,6 +9449,21 @@
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "RequirePINforRemoteOperation",
"code": 51,
"mfgCode": null,
"side": "server",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0",
"reportable": 0,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "ClusterRevision",
"code": 65533,
Expand Down Expand Up @@ -16369,4 +16504,4 @@
"deviceIdentifier": 22
}
]
}
}
Loading

0 comments on commit 1174727

Please sign in to comment.