Skip to content

Commit

Permalink
Fix broken gn_build.sh builds (#12279)
Browse files Browse the repository at this point in the history
#### Problem

Builds of the ‘fake’ platform (which are included in `gn_build.sh`)
fail since commit e0a8db7. That changed the default state of the
`CHIP_ENABLE_ROTATING_DEVICE_ID` flag, which excludes a definition
in `ConfigurationManagerImpl` in `src/platform/fake/ConfigurationManagerImpl.h`
but not in the corresponding base class.

#### Change overview

Remove the `#if`

#### Testing

`gn_build.sh`
  • Loading branch information
kpschoedel authored and pull[bot] committed Jan 4, 2024
1 parent 35db974 commit 107db51
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/platform/fake/ConfigurationManagerImpl.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ class ConfigurationManagerImpl : public ConfigurationManager
CHIP_ERROR StoreSetupPinCode(uint32_t setupPinCode) override { return CHIP_ERROR_NOT_IMPLEMENTED; }
CHIP_ERROR GetSetupDiscriminator(uint16_t & setupDiscriminator) override { return CHIP_ERROR_NOT_IMPLEMENTED; }
CHIP_ERROR StoreSetupDiscriminator(uint16_t setupDiscriminator) override { return CHIP_ERROR_NOT_IMPLEMENTED; }
#if CHIP_ENABLE_ROTATING_DEVICE_ID
CHIP_ERROR GetLifetimeCounter(uint16_t & lifetimeCounter) override { return CHIP_ERROR_NOT_IMPLEMENTED; }
#endif
CHIP_ERROR GetFailSafeArmed(bool & val) override { return CHIP_ERROR_NOT_IMPLEMENTED; }
CHIP_ERROR SetFailSafeArmed(bool val) override { return CHIP_ERROR_NOT_IMPLEMENTED; }
CHIP_ERROR GetBLEDeviceIdentificationInfo(Ble::ChipBLEDeviceIdentificationInfo & deviceIdInfo) override
Expand Down

0 comments on commit 107db51

Please sign in to comment.