-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for CASE session caching for session resume use cases (#1…
…1937) - Add tests for the CASE session cache - Update the CASESessionCachable struct to have only necessary members and rename the struct and APIs appropriately - Remove the tests that serilaize and deserilaize the CASE Session as its outdated
- Loading branch information
1 parent
dccd066
commit 1070088
Showing
9 changed files
with
450 additions
and
163 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* | ||
| * | ||
| * Copyright (c) 2021 Project CHIP Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include <protocols/secure_channel/CASESessionCache.h> | ||
|
|
||
| namespace chip { | ||
|
|
||
| CASESessionCache::CASESessionCache() {} | ||
|
|
||
| CASESessionCache::~CASESessionCache() | ||
| { | ||
| mCachePool.ForEachActiveObject([&](auto * ec) { | ||
| mCachePool.ReleaseObject(ec); | ||
| return true; | ||
| }); | ||
| } | ||
|
|
||
| CASESessionCachable * CASESessionCache::GetLRUSession() | ||
| { | ||
| uint64_t minTimeStamp = UINT64_MAX; | ||
| CASESessionCachable * lruSession = nullptr; | ||
| mCachePool.ForEachActiveObject([&](auto * ec) { | ||
| if (minTimeStamp > ec->mSessionSetupTimeStamp) | ||
| { | ||
| minTimeStamp = ec->mSessionSetupTimeStamp; | ||
| lruSession = ec; | ||
| } | ||
| return true; | ||
| }); | ||
| return lruSession; | ||
| } | ||
|
|
||
| CHIP_ERROR CASESessionCache::Add(CASESessionCachable & cachableSession) | ||
| { | ||
| // It's not an error if a device doesn't have cache for storing the sessions. | ||
| VerifyOrReturnError(mCachePool.Capacity() > 0, CHIP_NO_ERROR); | ||
|
|
||
| // If the cache is full, get the least recently used session index and release that. | ||
| if (mCachePool.Exhausted()) | ||
| { | ||
| mCachePool.ReleaseObject(GetLRUSession()); | ||
| } | ||
|
|
||
| mCachePool.CreateObject(cachableSession); | ||
| return CHIP_NO_ERROR; | ||
| } | ||
|
|
||
| CHIP_ERROR CASESessionCache::Remove(ResumptionID resumptionID) | ||
| { | ||
| CHIP_ERROR err = CHIP_NO_ERROR; | ||
| CASESession session; | ||
| mCachePool.ForEachActiveObject([&](auto * ec) { | ||
| if (resumptionID.data_equal(ResumptionID(ec->mResumptionId))) | ||
| { | ||
| mCachePool.ReleaseObject(ec); | ||
| } | ||
| return true; | ||
| }); | ||
|
|
||
| return err; | ||
| } | ||
|
|
||
| CHIP_ERROR CASESessionCache::Get(ResumptionID resumptionID, CASESessionCachable & outSessionCachable) | ||
| { | ||
| CHIP_ERROR err = CHIP_NO_ERROR; | ||
| bool found = false; | ||
| mCachePool.ForEachActiveObject([&](auto * ec) { | ||
| if (resumptionID.data_equal(ResumptionID(ec->mResumptionId))) | ||
| { | ||
| found = true; | ||
| outSessionCachable = *ec; | ||
| return false; | ||
| } | ||
| return true; | ||
| }); | ||
|
|
||
| if (!found) | ||
| { | ||
| err = CHIP_ERROR_PERSISTED_STORAGE_VALUE_NOT_FOUND; | ||
| } | ||
|
|
||
| return err; | ||
| } | ||
|
|
||
| CHIP_ERROR CASESessionCache::Get(const PeerId & peer, CASESessionCachable & outSessionCachable) | ||
| { | ||
| // TODO: Implement this based on peer id | ||
| return CHIP_NO_ERROR; | ||
| } | ||
|
|
||
| } // namespace chip |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * | ||
| * Copyright (c) 2021 Project CHIP Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <lib/core/CHIPError.h> | ||
| #include <lib/core/PeerId.h> | ||
| #include <protocols/secure_channel/CASESession.h> | ||
|
|
||
| namespace chip { | ||
|
|
||
| using ResumptionID = FixedByteSpan<kCASEResumptionIDSize>; | ||
|
|
||
| class CASESessionCache | ||
| { | ||
| public: | ||
| CASESessionCache(); | ||
| virtual ~CASESessionCache(); | ||
|
|
||
| CHIP_ERROR Add(CASESessionCachable & cachableSession); | ||
| CHIP_ERROR Remove(ResumptionID resumptionID); | ||
| CHIP_ERROR Get(ResumptionID resumptionID, CASESessionCachable & outCachableSession); | ||
| CHIP_ERROR Get(const PeerId & peer, CASESessionCachable & outCachableSession); | ||
|
|
||
| private: | ||
| BitMapObjectPool<CASESessionCachable, CHIP_CONFIG_CASE_SESSION_RESUME_CACHE_SIZE> mCachePool; | ||
| CASESessionCachable * GetLRUSession(); | ||
| }; | ||
|
|
||
| } // namespace chip |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.